[PATCH] dma-buf/sync_file: fix build warning with context format type

[PATCH] dma-buf/sync_file: fix build warning with context format type

[Gustavo Padovan]

From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>

Christian König changed fence context to a u64 type, so we need to
update all users accordingly.

Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
---

Should we get this via drm-misc to silent the warning added by the change
on the fence context?

 drivers/dma-buf/sync_file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma-buf/sync_file.c b/drivers/dma-buf/sync_file.c
index f08cf2d..9aaa608 100644
--- a/drivers/dma-buf/sync_file.c
+++ b/drivers/dma-buf/sync_file.c
@@ -82,7 +82,7 @@ struct sync_file *sync_file_create(struct fence *fence)
 
 	sync_file->num_fences = 1;
 	atomic_set(&sync_file->status, 1);
-	snprintf(sync_file->name, sizeof(sync_file->name), "%s-%s%d-%d",
+	snprintf(sync_file->name, sizeof(sync_file->name), "%s-%s%llu-%d",
 		 fence->ops->get_driver_name(fence),
 		 fence->ops->get_timeline_name(fence), fence->context,
 		 fence->seqno);
-- 
2.5.5

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] dma-buf/sync_file: fix build warning with context format type

[Sumit Semwal]

[-- Attachment #1.1: Type: text/plain, Size: 1308 bytes --]

Hi Gustavo,

On 03-Jun-2016 9:16 PM, "Gustavo Padovan" <gustavo@padovan.org> wrote:
>
> From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
>
> Christian König changed fence context to a u64 type, so we need to
> update all users accordingly.
>
> Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Thanks for the patch,
Acked-by: Sumit Semwal <sumit.semwal@linaro.org>
> ---
>
> Should we get this via drm-misc to silent the warning added by the change
> on the fence context?
Yes, please! :)

>
>  drivers/dma-buf/sync_file.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma-buf/sync_file.c b/drivers/dma-buf/sync_file.c
> index f08cf2d..9aaa608 100644
> --- a/drivers/dma-buf/sync_file.c
> +++ b/drivers/dma-buf/sync_file.c
> @@ -82,7 +82,7 @@ struct sync_file *sync_file_create(struct fence *fence)
>
>         sync_file->num_fences = 1;
>         atomic_set(&sync_file->status, 1);
> -       snprintf(sync_file->name, sizeof(sync_file->name), "%s-%s%d-%d",
> +       snprintf(sync_file->name, sizeof(sync_file->name), "%s-%s%llu-%d",
>                  fence->ops->get_driver_name(fence),
>                  fence->ops->get_timeline_name(fence), fence->context,
>                  fence->seqno);
> --
> 2.5.5
>

[-- Attachment #1.2: Type: text/html, Size: 1920 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] dma-buf/sync_file: fix build warning with context format type

[Daniel Vetter]

On Fri, Jun 03, 2016 at 11:27:31PM +0530, Sumit Semwal wrote:
> Hi Gustavo,
> 
> On 03-Jun-2016 9:16 PM, "Gustavo Padovan" <gustavo@padovan.org> wrote:
> >
> > From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> >
> > Christian König changed fence context to a u64 type, so we need to
> > update all users accordingly.
> >
> > Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> Thanks for the patch,
> Acked-by: Sumit Semwal <sumit.semwal@linaro.org>
> > ---
> >
> > Should we get this via drm-misc to silent the warning added by the change
> > on the fence context?
> Yes, please! :)

Done, thanks.
-Daniel

> 
> >
> >  drivers/dma-buf/sync_file.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/dma-buf/sync_file.c b/drivers/dma-buf/sync_file.c
> > index f08cf2d..9aaa608 100644
> > --- a/drivers/dma-buf/sync_file.c
> > +++ b/drivers/dma-buf/sync_file.c
> > @@ -82,7 +82,7 @@ struct sync_file *sync_file_create(struct fence *fence)
> >
> >         sync_file->num_fences = 1;
> >         atomic_set(&sync_file->status, 1);
> > -       snprintf(sync_file->name, sizeof(sync_file->name), "%s-%s%d-%d",
> > +       snprintf(sync_file->name, sizeof(sync_file->name), "%s-%s%llu-%d",
> >                  fence->ops->get_driver_name(fence),
> >                  fence->ops->get_timeline_name(fence), fence->context,
> >                  fence->seqno);
> > --
> > 2.5.5
> >

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel