From: Daniel Vetter <daniel@ffwll.ch>
To: Stefan Christ <s.christ@phytec.de>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/gma500: remove unnecessary stub for fb_ioctl()
Date: Thu, 28 Jul 2016 10:04:00 +0200 [thread overview]
Message-ID: <20160728080400.GH31475@phenom.ffwll.local> (raw)
In-Reply-To: <1469622270-10803-1-git-send-email-s.christ@phytec.de>
On Wed, Jul 27, 2016 at 02:24:30PM +0200, Stefan Christ wrote:
> Stub implementation of fb_ioctl can be omitted, because function
> do_fb_ioctl already returns -ENOTTY when fb_ioctl is not assigned.
>
> Signed-off-by: Stefan Christ <s.christ@phytec.de>
Applied to drm-misc, thanks.
-Daniel
> ---
> drivers/gpu/drm/gma500/framebuffer.c | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/gma500/framebuffer.c b/drivers/gpu/drm/gma500/framebuffer.c
> index 7440bf9..0fcdce0 100644
> --- a/drivers/gpu/drm/gma500/framebuffer.c
> +++ b/drivers/gpu/drm/gma500/framebuffer.c
> @@ -184,12 +184,6 @@ static int psbfb_mmap(struct fb_info *info, struct vm_area_struct *vma)
> return 0;
> }
>
> -static int psbfb_ioctl(struct fb_info *info, unsigned int cmd,
> - unsigned long arg)
> -{
> - return -ENOTTY;
> -}
> -
> static struct fb_ops psbfb_ops = {
> .owner = THIS_MODULE,
> .fb_check_var = drm_fb_helper_check_var,
> @@ -201,7 +195,6 @@ static struct fb_ops psbfb_ops = {
> .fb_imageblit = drm_fb_helper_cfb_imageblit,
> .fb_mmap = psbfb_mmap,
> .fb_sync = psbfb_sync,
> - .fb_ioctl = psbfb_ioctl,
> };
>
> static struct fb_ops psbfb_roll_ops = {
> @@ -215,7 +208,6 @@ static struct fb_ops psbfb_roll_ops = {
> .fb_imageblit = drm_fb_helper_cfb_imageblit,
> .fb_pan_display = psbfb_pan,
> .fb_mmap = psbfb_mmap,
> - .fb_ioctl = psbfb_ioctl,
> };
>
> static struct fb_ops psbfb_unaccel_ops = {
> @@ -228,7 +220,6 @@ static struct fb_ops psbfb_unaccel_ops = {
> .fb_copyarea = drm_fb_helper_cfb_copyarea,
> .fb_imageblit = drm_fb_helper_cfb_imageblit,
> .fb_mmap = psbfb_mmap,
> - .fb_ioctl = psbfb_ioctl,
> };
>
> /**
> --
> 1.9.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2016-07-28 8:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-27 12:24 [PATCH] drm/gma500: remove unnecessary stub for fb_ioctl() Stefan Christ
2016-07-28 8:04 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160728080400.GH31475@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=s.christ@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox