[PATCH] drm/gma500: remove unnecessary stub for fb_ioctl()

[PATCH] drm/gma500: remove unnecessary stub for fb_ioctl()

[Stefan Christ]

Stub implementation of fb_ioctl can be omitted, because function
do_fb_ioctl already returns -ENOTTY when fb_ioctl is not assigned.

Signed-off-by: Stefan Christ <s.christ@phytec.de>
---
 drivers/gpu/drm/gma500/framebuffer.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/drivers/gpu/drm/gma500/framebuffer.c b/drivers/gpu/drm/gma500/framebuffer.c
index 7440bf9..0fcdce0 100644
--- a/drivers/gpu/drm/gma500/framebuffer.c
+++ b/drivers/gpu/drm/gma500/framebuffer.c
@@ -184,12 +184,6 @@ static int psbfb_mmap(struct fb_info *info, struct vm_area_struct *vma)
 	return 0;
 }
 
-static int psbfb_ioctl(struct fb_info *info, unsigned int cmd,
-						unsigned long arg)
-{
-	return -ENOTTY;
-}
-
 static struct fb_ops psbfb_ops = {
 	.owner = THIS_MODULE,
 	.fb_check_var = drm_fb_helper_check_var,
@@ -201,7 +195,6 @@ static struct fb_ops psbfb_ops = {
 	.fb_imageblit = drm_fb_helper_cfb_imageblit,
 	.fb_mmap = psbfb_mmap,
 	.fb_sync = psbfb_sync,
-	.fb_ioctl = psbfb_ioctl,
 };
 
 static struct fb_ops psbfb_roll_ops = {
@@ -215,7 +208,6 @@ static struct fb_ops psbfb_roll_ops = {
 	.fb_imageblit = drm_fb_helper_cfb_imageblit,
 	.fb_pan_display = psbfb_pan,
 	.fb_mmap = psbfb_mmap,
-	.fb_ioctl = psbfb_ioctl,
 };
 
 static struct fb_ops psbfb_unaccel_ops = {
@@ -228,7 +220,6 @@ static struct fb_ops psbfb_unaccel_ops = {
 	.fb_copyarea = drm_fb_helper_cfb_copyarea,
 	.fb_imageblit = drm_fb_helper_cfb_imageblit,
 	.fb_mmap = psbfb_mmap,
-	.fb_ioctl = psbfb_ioctl,
 };
 
 /**
-- 
1.9.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/gma500: remove unnecessary stub for fb_ioctl()

[Daniel Vetter]

On Wed, Jul 27, 2016 at 02:24:30PM +0200, Stefan Christ wrote:
> Stub implementation of fb_ioctl can be omitted, because function
> do_fb_ioctl already returns -ENOTTY when fb_ioctl is not assigned.
> 
> Signed-off-by: Stefan Christ <s.christ@phytec.de>

Applied to drm-misc, thanks.
-Daniel
> ---
>  drivers/gpu/drm/gma500/framebuffer.c | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/drivers/gpu/drm/gma500/framebuffer.c b/drivers/gpu/drm/gma500/framebuffer.c
> index 7440bf9..0fcdce0 100644
> --- a/drivers/gpu/drm/gma500/framebuffer.c
> +++ b/drivers/gpu/drm/gma500/framebuffer.c
> @@ -184,12 +184,6 @@ static int psbfb_mmap(struct fb_info *info, struct vm_area_struct *vma)
>  	return 0;
>  }
>  
> -static int psbfb_ioctl(struct fb_info *info, unsigned int cmd,
> -						unsigned long arg)
> -{
> -	return -ENOTTY;
> -}
> -
>  static struct fb_ops psbfb_ops = {
>  	.owner = THIS_MODULE,
>  	.fb_check_var = drm_fb_helper_check_var,
> @@ -201,7 +195,6 @@ static struct fb_ops psbfb_ops = {
>  	.fb_imageblit = drm_fb_helper_cfb_imageblit,
>  	.fb_mmap = psbfb_mmap,
>  	.fb_sync = psbfb_sync,
> -	.fb_ioctl = psbfb_ioctl,
>  };
>  
>  static struct fb_ops psbfb_roll_ops = {
> @@ -215,7 +208,6 @@ static struct fb_ops psbfb_roll_ops = {
>  	.fb_imageblit = drm_fb_helper_cfb_imageblit,
>  	.fb_pan_display = psbfb_pan,
>  	.fb_mmap = psbfb_mmap,
> -	.fb_ioctl = psbfb_ioctl,
>  };
>  
>  static struct fb_ops psbfb_unaccel_ops = {
> @@ -228,7 +220,6 @@ static struct fb_ops psbfb_unaccel_ops = {
>  	.fb_copyarea = drm_fb_helper_cfb_copyarea,
>  	.fb_imageblit = drm_fb_helper_cfb_imageblit,
>  	.fb_mmap = psbfb_mmap,
> -	.fb_ioctl = psbfb_ioctl,
>  };
>  
>  /**
> -- 
> 1.9.1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel