[PATCH] drm/doc: Fix vga_switcheroo xref

[PATCH] drm/doc: Fix vga_switcheroo xref

[Daniel Vetter]

Reported-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 Documentation/gpu/vga-switcheroo.rst | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/gpu/vga-switcheroo.rst b/Documentation/gpu/vga-switcheroo.rst
index 463a74fc40d1..cbbdb994f1dd 100644
--- a/Documentation/gpu/vga-switcheroo.rst
+++ b/Documentation/gpu/vga-switcheroo.rst
@@ -1,3 +1,5 @@
+.. _vga_switcheroo:
+
 ==============
 VGA Switcheroo
 ==============
-- 
2.9.3

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/doc: Fix vga_switcheroo xref

[Chris Wilson]

On Wed, Aug 24, 2016 at 12:19:15PM +0200, Daniel Vetter wrote:
> Reported-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
>  Documentation/gpu/vga-switcheroo.rst | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/gpu/vga-switcheroo.rst b/Documentation/gpu/vga-switcheroo.rst
> index 463a74fc40d1..cbbdb994f1dd 100644
> --- a/Documentation/gpu/vga-switcheroo.rst
> +++ b/Documentation/gpu/vga-switcheroo.rst
> @@ -1,3 +1,5 @@
> +.. _vga_switcheroo:


Ok, so this creates a label that can be used as target of :ref: as used
by drm-internals.rst.

Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

Still learning rst.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/doc: Fix vga_switcheroo xref

[Lukas Wunner]

On Wed, Aug 24, 2016 at 11:31:47AM +0100, Chris Wilson wrote:
> On Wed, Aug 24, 2016 at 12:19:15PM +0200, Daniel Vetter wrote:
> > Reported-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > ---
> >  Documentation/gpu/vga-switcheroo.rst | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/Documentation/gpu/vga-switcheroo.rst b/Documentation/gpu/vga-switcheroo.rst
> > index 463a74fc40d1..cbbdb994f1dd 100644
> > --- a/Documentation/gpu/vga-switcheroo.rst
> > +++ b/Documentation/gpu/vga-switcheroo.rst
> > @@ -1,3 +1,5 @@
> > +.. _vga_switcheroo:
> 
> Ok, so this creates a label that can be used as target of :ref: as used
> by drm-internals.rst.
> 
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> 
> Still learning rst.

:-)

The label had already been there since commit fb001dfd7e77
("vga_switcheroo: Sphinxify docs") but Daniel accidentaly
deleted it with b754b35b089d ("vgaarbiter: rst-ifiy and
polish kerneldoc").

Best regards,

Lukas
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/doc: Fix vga_switcheroo xref

[Daniel Vetter]

On Wed, Aug 24, 2016 at 12:40:01PM +0200, Lukas Wunner wrote:
> On Wed, Aug 24, 2016 at 11:31:47AM +0100, Chris Wilson wrote:
> > On Wed, Aug 24, 2016 at 12:19:15PM +0200, Daniel Vetter wrote:
> > > Reported-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > > ---
> > >  Documentation/gpu/vga-switcheroo.rst | 2 ++
> > >  1 file changed, 2 insertions(+)
> > > 
> > > diff --git a/Documentation/gpu/vga-switcheroo.rst b/Documentation/gpu/vga-switcheroo.rst
> > > index 463a74fc40d1..cbbdb994f1dd 100644
> > > --- a/Documentation/gpu/vga-switcheroo.rst
> > > +++ b/Documentation/gpu/vga-switcheroo.rst
> > > @@ -1,3 +1,5 @@
> > > +.. _vga_switcheroo:
> > 
> > Ok, so this creates a label that can be used as target of :ref: as used
> > by drm-internals.rst.
> > 
> > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> > 
> > Still learning rst.
> 
> :-)
> 
> The label had already been there since commit fb001dfd7e77
> ("vga_switcheroo: Sphinxify docs") but Daniel accidentaly
> deleted it with b754b35b089d ("vgaarbiter: rst-ifiy and
> polish kerneldoc").

Oops. Added a Fixes: line with this sha1 and applied to drm-misc.

Also still learning rst ... ;-)

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel