drm/atmel-hlcdc: connector type & fbdev mode settings

drm/atmel-hlcdc: connector type & fbdev mode settings

[Hyung Jin Jung]

According to Atmel's guideline... http://www.at91.com/linux4sam/bin/view/Linux4SAM/UsingAtmelDRMDriver

the "fbdev emulation mode" could be set from kernel command line (LVDS-1:...)
however, driver register it as DRM_MODE_CONNECTOR_Unknown connector.

Actually we using sama5d3x with LVDS cable so that below patch would be correct.
But I don't know the other case such as HDMI, composite... 

Do we need to consider using DT or auto-detection??

Signed-off-by: HyungJin Jung <realbright@lgcns.com>
---
 drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c
index 6119b50..da97efe
--- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c
+++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c
@@ -208,7 +208,7 @@ static int atmel_hlcdc_attach_endpoint(struct drm_device *dev,
 				&atmel_hlcdc_panel_connector_helper_funcs);
 		ret = drm_connector_init(dev, &output->connector,
 					 &atmel_hlcdc_panel_connector_funcs,
-					 DRM_MODE_CONNECTOR_Unknown);
+					 DRM_MODE_CONNECTOR_LVDS);
 		if (ret)
 			goto err_encoder_cleanup;
 
-- 
1.9.1

BR,
Davy

Re: drm/atmel-hlcdc: connector type & fbdev mode settings

[Boris Brezillon]

On Wed, 31 Aug 2016 11:29:53 +0900
Hyung Jin Jung <realbright@lgcns.com> wrote:

> According to Atmel's guideline... http://www.at91.com/linux4sam/bin/view/Linux4SAM/UsingAtmelDRMDriver
> 
> the "fbdev emulation mode" could be set from kernel command line (LVDS-1:...)
> however, driver register it as DRM_MODE_CONNECTOR_Unknown connector.

Just adapt the command line with Unknown-1:...

> 
> Actually we using sama5d3x with LVDS cable so that below patch would be correct.

No it wouldn't. The sama5 SoC is providing a raw RGB interface, so if
you really have an LVDS interface on your board this means you have a
bridge in the middle. This bridge should be represented in the DT, and
attached to a driver in the kernel.

> But I don't know the other case such as HDMI, composite... 
> 
> Do we need to consider using DT or auto-detection??
> 
> Signed-off-by: HyungJin Jung <realbright@lgcns.com>
> ---
>  drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c
> index 6119b50..da97efe
> --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c
> +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c
> @@ -208,7 +208,7 @@ static int atmel_hlcdc_attach_endpoint(struct drm_device *dev,
>  				&atmel_hlcdc_panel_connector_helper_funcs);
>  		ret = drm_connector_init(dev, &output->connector,
>  					 &atmel_hlcdc_panel_connector_funcs,
> -					 DRM_MODE_CONNECTOR_Unknown);
> +					 DRM_MODE_CONNECTOR_LVDS);
>  		if (ret)
>  			goto err_encoder_cleanup;
>  

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[RE]Re: drm/atmel-hlcdc: connector type & fbdev mode settings

[정형진]

[-- Attachment #1.1: Type: text/plain, Size: 1266 bytes --]

Ah.. yes it is. sama5 has only raw RGB interface. I confused with other
device.
and I also checked your previos commit. (LVDS -> Unknown)

Atmel's wiki have to be updated.

------------------------------------------------------------------------
------------------------------------------
상기 메시지와 첨부화일 내에는 비밀정보가 포함되어 있을 수 있으며, 지정된 수신자에 한하여 조회 및 사용될 수 있습니다. 만약
송신자의 실수로 인하여 상기 메시지를 수신하였다면, 송신자에게 메시지를 반송해 주시고, 원본 메시지와 모든 사본을 폐기해 주시기
바랍니다.
상기 메시지의 전체 또는 일부에 대해 무단 열람, 사용, 공개, 배포하는 것은 금지되어 있습니다. (주)LG CNS
This message and its attachments may contain confidential information,
and they are intended to be viewed or used by only the individuals
specified in the message.If you have received this message in an error
from the sender, please contact the sender immediately to notify the
error and delete all of the message and its copies.It is prohibited to
view, use, make public and/or distribute part or whole of this message
without written permission.


[-- Attachment #1.2: Type: text/html, Size: 2019 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel