From: Daniel Vetter <daniel@ffwll.ch>
To: Vincent Abriou <vincent.abriou@st.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
Fabien Dessenne <fabien.dessenne@st.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm: remove useless parameters from drm_pick_cmdline_mode function
Date: Mon, 9 Jan 2017 11:24:57 +0100 [thread overview]
Message-ID: <20170109102457.bv3rdec4srknq652@phenom.ffwll.local> (raw)
In-Reply-To: <1483721084-20278-2-git-send-email-vincent.abriou@st.com>
On Fri, Jan 06, 2017 at 05:44:43PM +0100, Vincent Abriou wrote:
> drm_pick_cmdline_mode width and height parameters are useless.
> Just remove them.
>
> Cc: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Signed-off-by: Vincent Abriou <vincent.abriou@st.com>
Applied, thanks a lot. I'll wait for someone else to review patch 2 before
merging it.
-Daniel
> ---
> drivers/gpu/drm/drm_fb_helper.c | 7 +++----
> drivers/gpu/drm/i915/intel_fbdev.c | 2 +-
> include/drm/drm_fb_helper.h | 3 +--
> 3 files changed, 5 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
> index e934b54..77d9ac6 100644
> --- a/drivers/gpu/drm/drm_fb_helper.c
> +++ b/drivers/gpu/drm/drm_fb_helper.c
> @@ -1748,8 +1748,7 @@ static bool drm_has_cmdline_mode(struct drm_fb_helper_connector *fb_connector)
> return fb_connector->connector->cmdline_mode.specified;
> }
>
> -struct drm_display_mode *drm_pick_cmdline_mode(struct drm_fb_helper_connector *fb_helper_conn,
> - int width, int height)
> +struct drm_display_mode *drm_pick_cmdline_mode(struct drm_fb_helper_connector *fb_helper_conn)
> {
> struct drm_cmdline_mode *cmdline_mode;
> struct drm_display_mode *mode;
> @@ -1867,7 +1866,7 @@ static bool drm_target_cloned(struct drm_fb_helper *fb_helper,
> if (!enabled[i])
> continue;
> fb_helper_conn = fb_helper->connector_info[i];
> - modes[i] = drm_pick_cmdline_mode(fb_helper_conn, width, height);
> + modes[i] = drm_pick_cmdline_mode(fb_helper_conn);
> if (!modes[i]) {
> can_clone = false;
> break;
> @@ -1989,7 +1988,7 @@ static bool drm_target_preferred(struct drm_fb_helper *fb_helper,
> fb_helper_conn->connector->base.id);
>
> /* got for command line mode first */
> - modes[i] = drm_pick_cmdline_mode(fb_helper_conn, width, height);
> + modes[i] = drm_pick_cmdline_mode(fb_helper_conn);
> if (!modes[i]) {
> DRM_DEBUG_KMS("looking for preferred mode on connector %d %d\n",
> fb_helper_conn->connector->base.id, fb_helper_conn->connector->tile_group ? fb_helper_conn->connector->tile_group->id : 0);
> diff --git a/drivers/gpu/drm/i915/intel_fbdev.c b/drivers/gpu/drm/i915/intel_fbdev.c
> index beb0898..4b302f8 100644
> --- a/drivers/gpu/drm/i915/intel_fbdev.c
> +++ b/drivers/gpu/drm/i915/intel_fbdev.c
> @@ -447,7 +447,7 @@ static bool intel_fb_initial_config(struct drm_fb_helper *fb_helper,
> connector->name);
>
> /* go for command line mode first */
> - modes[i] = drm_pick_cmdline_mode(fb_conn, width, height);
> + modes[i] = drm_pick_cmdline_mode(fb_conn);
>
> /* try for preferred next */
> if (!modes[i]) {
> diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h
> index 975deed..48e09e8 100644
> --- a/include/drm/drm_fb_helper.h
> +++ b/include/drm/drm_fb_helper.h
> @@ -295,8 +295,7 @@ struct drm_display_mode *
> drm_has_preferred_mode(struct drm_fb_helper_connector *fb_connector,
> int width, int height);
> struct drm_display_mode *
> -drm_pick_cmdline_mode(struct drm_fb_helper_connector *fb_helper_conn,
> - int width, int height);
> +drm_pick_cmdline_mode(struct drm_fb_helper_connector *fb_helper_conn);
>
> int drm_fb_helper_add_one_connector(struct drm_fb_helper *fb_helper, struct drm_connector *connector);
> int drm_fb_helper_remove_one_connector(struct drm_fb_helper *fb_helper,
> --
> 2.7.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-01-09 10:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-06 16:44 [PATCH 0/2] get fbdev size from cmdline if no connector found Vincent Abriou
2017-01-06 16:44 ` [PATCH 1/2] drm: remove useless parameters from drm_pick_cmdline_mode function Vincent Abriou
2017-01-09 10:24 ` Daniel Vetter [this message]
2017-01-06 16:44 ` [PATCH 2/2] drm: get fbdev size from cmdline if no connector found Vincent Abriou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170109102457.bv3rdec4srknq652@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=fabien.dessenne@st.com \
--cc=vincent.abriou@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox