dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Chad Versace <chadversary@chromium.org>
To: Gustavo Padovan <gustavo@padovan.org>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Daniel Vetter <daniel@ffwll.ch>,
	dri-devel@lists.freedesktop.org, Rob Clark <robdclark@gmail.com>,
	Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: Why does OUT_FENCE_PTR point not to an fd (s32) but to an s64?
Date: Fri, 13 Jan 2017 13:31:19 -0800	[thread overview]
Message-ID: <20170113213119.GA69565@chadversary.pdx.corp.google.com> (raw)
In-Reply-To: <20170112193407.GD16017@joana>

On Thu 12 Jan 2017, Gustavo Padovan wrote:
> 2017-01-12 Laurent Pinchart <laurent.pinchart@ideasonboard.com>:
> 
> > Hi Daniel,
> > 
> > On Thursday 12 Jan 2017 20:26:40 Daniel Vetter wrote:
> > > On Thu, Jan 12, 2017 at 05:17:26PM -0200, Gustavo Padovan wrote:
> > > > 2017-01-10 Laurent Pinchart <laurent.pinchart@ideasonboard.com>:
> > > >> On Monday 09 Jan 2017 11:23:23 Daniel Vetter wrote:
> > > >>> On Fri, Jan 06, 2017 at 01:04:55PM -0800, Chad Versace wrote:
> > > >>>> Was this a mistake in the API? If so, can we fix this ABI mistake
> > > >>>> before kernel consumers rely on this?

[...]

> I'd expect users defining an int and hitting the issue Chad hit instead
> of going to long types. So I hope we are safe here. I'll prepare a
> patch to make it s32.

Thanks for fixing this. I'm glad we caught it before the uabi became
frozen.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

      reply	other threads:[~2017-01-13 21:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-06 21:04 Why does OUT_FENCE_PTR point not to an fd (s32) but to an s64? Chad Versace
2017-01-06 21:13 ` Chad Versace
2017-01-09 10:23 ` Daniel Vetter
2017-01-10 20:58   ` Laurent Pinchart
2017-01-12 19:17     ` Gustavo Padovan
2017-01-12 19:26       ` Daniel Vetter
2017-01-12 19:29         ` Laurent Pinchart
2017-01-12 19:34           ` Gustavo Padovan
2017-01-13 21:31             ` Chad Versace [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170113213119.GA69565@chadversary.pdx.corp.google.com \
    --to=chadversary@chromium.org \
    --cc=chris@chris-wilson.co.uk \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gustavo@padovan.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=robdclark@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox