Re: RFC: drm-misc for small drivers?

[Liviu Dudau <Liviu.Dudau@arm.com>]

On Fri, Jan 27, 2017 at 07:55:22AM +0100, Daniel Vetter wrote:
> On Thu, Jan 26, 2017 at 9:48 PM, Liviu Dudau <liviu@dudau.co.uk> wrote:
> >> I'm not certain number of people is a good metric, TBH. There are cases
> >> where a lot of people are working on a driver, but the patches are not being
> >> merged to the maintainer tree. In these cases, it makes sense to migrate the
> >> driver to -misc and have the community merge the patches.
> >
> > Sorry, I should've been more explicit: I was referring to the number of
> > contributors with public commit rights, not all the engineers involved. In
> > Mali DP's case we do most of the development in the open, so all the engineers
> > are free to merge the patches into the current public git tree after internal
> > review that tries to catch the evident issues.
> 
> Not sure, but this sounds like you do internal review and then just
> push to the public tree. That's not good, since it makes cross-driver
> collab harder, and it makes it much harder for external people to
> contribute to your driver in general. Upstream is about cross
> vendor/user/osv/whomever collaboration in the open, if you really do
> review internall I strongly urge you to do all patch submission&review
> on dri-devel. That's how all the other drivers work (well
> amd/i915/nouveau have their own separate mailing lists because we'd
> drown dri-devel), and it's the expectation. It would definitely be the
> expectation if arm display is managed in drm-misc :-)

Yes, we do some lite internal review for some very simple reasons: people are still
getting used to submitting patches to mainline so they make easily fixable mistakes
that we can weed out with the internal review; the second reason (and that applies
only when we add new functionality to the driver) is to scan for possible patent
violations. I'm pretty sure that something similar exists in most companies.

Note that this does not exclude the public mailing lists. We have received contributions
via dri-devel ML (look at the last pull request, it features one external contributor)
and there is no replacement internally for dri-devel. The malidp@foss.arm.com mailing
list exists only to allow for a quick response time from any of the contributors in
case some of us are travelling or on holiday which you don't get with direct email
addresses.

I've made that clear in private conversations and I wil re-iterate it here: Mali DP team
is mainline first and cross-driver focused. However, we are not operating as a separate
entity from the rest of ARM, so we have to obey some internal processes.

Best regards,
Liviu

> -Daniel
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> +41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel