From: Thierry Reding <thierry.reding@gmail.com>
To: Fabio Estevam <fabio.estevam@nxp.com>
Cc: marex@denx.de, breno.lima@nxp.com, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: mxsfb: Implement drm_panel handling
Date: Wed, 1 Feb 2017 18:22:16 +0100 [thread overview]
Message-ID: <20170201172216.GA27271@ulmo.ba.sec> (raw)
In-Reply-To: <1485969587-3630-1-git-send-email-fabio.estevam@nxp.com>
[-- Attachment #1.1: Type: text/plain, Size: 872 bytes --]
On Wed, Feb 01, 2017 at 03:19:47PM -0200, Fabio Estevam wrote:
> Currently when the 'power-supply' regulator is passed via device tree
> it does not actually work since drm_panel_prepare()/drm_panel_enable()
> are never called.
>
> Quoting Thierry Reding: "It should really call drm_panel_prepare() and
> drm_panel_enable() while switching on the display pipeline and
> drm_panel_disable(), followed by drm_panel_unprepare() while switching
> off the display pipeline."
>
> So do as suggested, so that the 'power-supply' regulator can be functional.
>
> Reported-by: Breno Lima <breno.lima@nxp.com>
> Suggested-by: Thierry Reding <thierry.reding@gmail.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> drivers/gpu/drm/mxsfb/mxsfb_drv.c | 4 ++++
> 1 file changed, 4 insertions(+)
Reviewed-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-02-01 17:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-01 17:19 [PATCH] drm: mxsfb: Implement drm_panel handling Fabio Estevam
2017-02-01 17:22 ` Thierry Reding [this message]
2017-02-01 19:05 ` Breno Matheus Lima
2017-02-07 21:44 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170201172216.GA27271@ulmo.ba.sec \
--to=thierry.reding@gmail.com \
--cc=breno.lima@nxp.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=fabio.estevam@nxp.com \
--cc=marex@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox