From: Shawn Guo <shawnguo@kernel.org>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Liviu Dudau <liviu.dudau@arm.com>,
dri-devel@lists.freedesktop.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [RFC PATCH v2 0/5] Add vblank hooks to struct drm_crtc_funcs
Date: Tue, 7 Feb 2017 16:34:38 +0800 [thread overview]
Message-ID: <20170207083437.GJ3407@dragon> (raw)
In-Reply-To: <20170207073246.k2j6lhvy4ev26n4c@phenom.ffwll.local>
On Tue, Feb 07, 2017 at 08:32:46AM +0100, Daniel Vetter wrote:
> On Tue, Jan 24, 2017 at 08:55:35AM +0100, Daniel Vetter wrote:
> > On Sun, Jan 22, 2017 at 02:09:01PM +0800, Shawn Guo wrote:
> > > From: Shawn Guo <shawn.guo@linaro.org>
> > >
> > > The vblank is mostly CRTC specific and implemented as part of CRTC
> > > driver. The first patch adds 3 vblank core-driver hooks into struct
> > > drm_crtc_funcs, and wraps around core vblank handling code to use the
> > > new hooks for modern MODESET drivers and the ones in struct drm_driver
> > > as fallback for legacy drivers.
> > >
> > > The other patches in the series are to demonstrate how the new hooks
> > > are going to influence the driver code. There are more drivers than
> > > the ones included here can be converted. But before doing that, I would
> > > like to get some feedbacks first, expecially on how .get_vblank_counter
> > > should be converted when it's being drm_vblank_no_hw_counter().
> > >
> > > .get_vblank_counter = drm_vblank_no_hw_counter
> >
> > I dropped some suggestions about this onto patch 3. Thanks for doing this,
> > I think it looks rather pretty.
>
> Just to check: Do you plan to resend this series with my comments on the
> first patch addressed? I really like this, so I guess you could drop the
> RFC part and then we give maintainers a week or two for reviews and land
> it into drm-misc for 4.12 ...
Sorry for being late due to Chinese New Year Holidays. The new version
is on the way, and will be on the list in a couple of hours.
Shawn
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2017-02-07 8:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-22 6:09 [RFC PATCH v2 0/5] Add vblank hooks to struct drm_crtc_funcs Shawn Guo
2017-01-22 6:09 ` [RFC PATCH v2 1/5] drm: add " Shawn Guo
2017-01-24 7:54 ` Daniel Vetter
2017-01-22 6:09 ` [RFC PATCH v2 2/5] drm: hdlcd: use vblank hooks in " Shawn Guo
2017-01-27 17:02 ` Liviu Dudau
2017-01-22 6:09 ` [RFC PATCH v2 3/5] drm: zte: zx_vou_enable[disable]_vblank can be static Shawn Guo
2017-01-22 6:09 ` [RFC PATCH v2 4/5] drm: rockchip: remove struct rockchip_crtc_funcs Shawn Guo
2017-01-22 6:09 ` [RFC PATCH v2 5/5] drm: imx: remove struct imx_drm_crtc and imx_drm_crtc_helper_funcs Shawn Guo
2017-01-24 7:55 ` [RFC PATCH v2 0/5] Add vblank hooks to struct drm_crtc_funcs Daniel Vetter
2017-02-07 7:32 ` Daniel Vetter
2017-02-07 8:34 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170207083437.GJ3407@dragon \
--to=shawnguo@kernel.org \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=liviu.dudau@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox