From: Dan Carpenter <dan.carpenter@oracle.com>
To: a.hajda@samsung.com
Cc: linux-samsung-soc@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: [bug report] drm/exynos/decon5433: configure sysreg in case of hardware trigger
Date: Tue, 14 Feb 2017 10:48:42 +0300 [thread overview]
Message-ID: <20170214074842.GA3772@mwanda> (raw)
Hello Andrzej Hajda,
The patch b93c2e8b5d9d: "drm/exynos/decon5433: configure sysreg in
case of hardware trigger" from Feb 1, 2017, leads to the following
static checker warning:
drivers/gpu/drm/exynos/exynos5433_drm_decon.c:132 decon_setup_trigger()
'0x20000001 | 0x1' has '0x1' set on both sides
drivers/gpu/drm/exynos/exynos5433_drm_decon.c
125 static void decon_setup_trigger(struct decon_context *ctx)
126 {
127 if (!(ctx->out_type & (IFTYPE_I80 | I80_HW_TRG)))
128 return;
129
130 if (!(ctx->out_type & I80_HW_TRG)) {
131 writel(TRIGCON_TE_AUTO_MASK | TRIGCON_SWTRIGEN
132 | TRIGCON_TE_AUTO_MASK | TRIGCON_SWTRIGEN,
The mask is repeated twice. No idea what was intended.
133 ctx->addr + DECON_TRIGCON);
134 return;
135 }
136
137 writel(TRIGCON_TRIGEN_PER_F | TRIGCON_TRIGEN_F | TRIGCON_HWTRIGMASK
138 | TRIGCON_HWTRIGEN, ctx->addr + DECON_TRIGCON);
139
140 if (regmap_update_bits(ctx->sysreg, DSD_CFG_MUX,
141 DSD_CFG_MUX_TE_UNMASK_GLOBAL, ~0))
142 DRM_ERROR("Cannot update sysreg.\n");
143 }
regards,
dan carpenter
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
reply other threads:[~2017-02-14 7:48 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170214074842.GA3772@mwanda \
--to=dan.carpenter@oracle.com \
--cc=a.hajda@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox