[bug report] drm/exynos/decon5433: configure sysreg in case of hardware trigger

[bug report] drm/exynos/decon5433: configure sysreg in case of hardware trigger

[Dan Carpenter]

Hello Andrzej Hajda,

The patch b93c2e8b5d9d: "drm/exynos/decon5433: configure sysreg in
case of hardware trigger" from Feb 1, 2017, leads to the following
static checker warning:

	drivers/gpu/drm/exynos/exynos5433_drm_decon.c:132 decon_setup_trigger()
	'0x20000001 | 0x1' has '0x1' set on both sides

drivers/gpu/drm/exynos/exynos5433_drm_decon.c
   125  static void decon_setup_trigger(struct decon_context *ctx)
   126  {
   127          if (!(ctx->out_type & (IFTYPE_I80 | I80_HW_TRG)))
   128                  return;
   129  
   130          if (!(ctx->out_type & I80_HW_TRG)) {
   131                  writel(TRIGCON_TE_AUTO_MASK | TRIGCON_SWTRIGEN
   132                         | TRIGCON_TE_AUTO_MASK | TRIGCON_SWTRIGEN,

The mask is repeated twice.  No idea what was intended.

   133                         ctx->addr + DECON_TRIGCON);
   134                  return;
   135          }
   136  
   137          writel(TRIGCON_TRIGEN_PER_F | TRIGCON_TRIGEN_F | TRIGCON_HWTRIGMASK
   138                 | TRIGCON_HWTRIGEN, ctx->addr + DECON_TRIGCON);
   139  
   140          if (regmap_update_bits(ctx->sysreg, DSD_CFG_MUX,
   141                                 DSD_CFG_MUX_TE_UNMASK_GLOBAL, ~0))
   142                  DRM_ERROR("Cannot update sysreg.\n");
   143  }

regards,
dan carpenter
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel