dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Varad Gautam <varadgautam@gmail.com>
To: dri-devel@lists.freedesktop.org
Cc: Varad Gautam <varad.gautam@collabora.com>
Subject: [PATCH 09/12] drm/cirrus: send vblank on crtc atomic_flush
Date: Fri,  8 Sep 2017 19:05:14 +0530	[thread overview]
Message-ID: <20170908133517.18715-10-varadgautam@gmail.com> (raw)
In-Reply-To: <20170908133517.18715-1-varadgautam@gmail.com>

From: Varad Gautam <varad.gautam@collabora.com>

the hardware does not provide interrupts on vblank, so we just send a fake
vblank event on atomic_flush.

Signed-off-by: Varad Gautam <varad.gautam@collabora.com>
---
 drivers/gpu/drm/cirrus/cirrus_mode.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/drivers/gpu/drm/cirrus/cirrus_mode.c b/drivers/gpu/drm/cirrus/cirrus_mode.c
index ee023c865165..4c95447ac445 100644
--- a/drivers/gpu/drm/cirrus/cirrus_mode.c
+++ b/drivers/gpu/drm/cirrus/cirrus_mode.c
@@ -217,6 +217,23 @@ static void cirrus_crtc_destroy(struct drm_crtc *crtc)
 	kfree(cirrus_crtc);
 }
 
+static void cirrus_crtc_atomic_flush(struct drm_crtc *crtc,
+				     struct drm_crtc_state *old_crtc_state)
+{
+	struct drm_device *dev = crtc->dev;
+	struct drm_pending_vblank_event *event;
+	unsigned long flags;
+
+	if (crtc->state && crtc->state->event) {
+		event = crtc->state->event;
+		crtc->state->event = NULL;
+
+		spin_lock_irqsave(&dev->event_lock, flags);
+		drm_crtc_send_vblank_event(crtc, event);
+		spin_unlock_irqrestore(&dev->event_lock, flags);
+	}
+}
+
 /* These provide the minimum set of functions required to handle a CRTC */
 static const struct drm_crtc_funcs cirrus_crtc_funcs = {
 	.gamma_set = cirrus_crtc_gamma_set,
@@ -234,6 +251,7 @@ static const struct drm_crtc_helper_funcs cirrus_helper_funcs = {
 	.mode_set_nofb = cirrus_mode_set_nofb,
 	.prepare = cirrus_crtc_prepare,
 	.commit = cirrus_crtc_commit,
+	.atomic_flush = cirrus_crtc_atomic_flush,
 };
 
 static int cirrus_plane_update(struct drm_plane *plane,
-- 
2.13.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2017-09-08 13:36 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-08 13:35 [PATCH 00/12] atomic modesetting for cirrus v2 Varad Gautam
2017-09-08 13:35 ` [PATCH 01/12] drm/cirrus: split out bo unpinning from cirrus_bo_push_sysram Varad Gautam
2017-09-08 13:35 ` [PATCH 02/12] drm/cirrus: add drm_read to cirrus_driver_fops Varad Gautam
2017-09-08 13:35 ` [PATCH 03/12] drm/cirrus: do not disable outputs on fbdev init for atomic Varad Gautam
2017-09-08 13:35 ` [PATCH 04/12] drm/cirrus: initialize start and size fields Varad Gautam
2017-09-11  8:23   ` Gerd Hoffmann
2017-09-08 13:35 ` [PATCH 05/12] drm/cirrus: hardcode vram size Varad Gautam
2017-09-11  8:31   ` Gerd Hoffmann
2017-09-08 13:35 ` [PATCH 06/12] drm/cirrus: implement PRIME export for cirrus Varad Gautam
2017-09-08 13:35 ` [PATCH 07/12] drm/cirrus: use universal plane interfaces for primary plane Varad Gautam
2017-09-08 13:35 ` [PATCH 08/12] drm/cirrus: use atomic transition helpers for plane and crtc Varad Gautam
2017-09-08 13:35 ` Varad Gautam [this message]
2017-09-08 13:35 ` [PATCH 10/12] drm/cirrus: use atomic handlers " Varad Gautam
2017-09-08 13:35 ` [PATCH 11/12] drm/cirrus: implement atomic hardware cursor support Varad Gautam
2017-09-11  8:37   ` Gerd Hoffmann
2017-09-08 13:35 ` [PATCH 12/12] drm/cirrus: advertise DRIVER_ATOMIC Varad Gautam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170908133517.18715-10-varadgautam@gmail.com \
    --to=varadgautam@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=varad.gautam@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox