From: Varad Gautam <varadgautam@gmail.com>
To: dri-devel@lists.freedesktop.org
Cc: "Stéphane Marchesin" <marcheu@chromium.org>,
"Zach Reizner" <zachr@chromium.org>
Subject: [PATCH 05/12] drm/cirrus: hardcode vram size
Date: Fri, 8 Sep 2017 19:05:10 +0530 [thread overview]
Message-ID: <20170908133517.18715-6-varadgautam@gmail.com> (raw)
In-Reply-To: <20170908133517.18715-1-varadgautam@gmail.com>
From: Zach Reizner <zachr@google.com>
There is no reliable way of detecting actual VRAM size, which is
important in the case of cirrus because cursor data is always stored in
the last 16K of VRAM. Because qemu effectivaly hardcodes 4MB but reports
32MB, we hardcode 4MB in the cirrus driver to ensure the cursor works
properly.
initially reviewed at: https://chromium-review.googlesource.com/411344
Signed-off-by: Zach Reizner <zachr@chromium.org>
CC: Stéphane Marchesin <marcheu@chromium.org>
---
drivers/gpu/drm/cirrus/cirrus_main.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/cirrus/cirrus_main.c b/drivers/gpu/drm/cirrus/cirrus_main.c
index b5f528543956..332bb2169508 100644
--- a/drivers/gpu/drm/cirrus/cirrus_main.c
+++ b/drivers/gpu/drm/cirrus/cirrus_main.c
@@ -98,7 +98,12 @@ static int cirrus_vram_init(struct cirrus_device *cdev)
{
/* BAR 0 is VRAM */
cdev->mc.vram_base = pci_resource_start(cdev->dev->pdev, 0);
- cdev->mc.vram_size = pci_resource_len(cdev->dev->pdev, 0);
+
+ /*
+ * While we can use the entire PCI bar for VRAM, qemu always expects to
+ * find the cursor data at the 4M - 16K point.
+ */
+ cdev->mc.vram_size = 4 * 1024 * 1024;
if (!request_mem_region(cdev->mc.vram_base, cdev->mc.vram_size,
"cirrusdrmfb_vram")) {
--
2.13.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-09-08 13:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-08 13:35 [PATCH 00/12] atomic modesetting for cirrus v2 Varad Gautam
2017-09-08 13:35 ` [PATCH 01/12] drm/cirrus: split out bo unpinning from cirrus_bo_push_sysram Varad Gautam
2017-09-08 13:35 ` [PATCH 02/12] drm/cirrus: add drm_read to cirrus_driver_fops Varad Gautam
2017-09-08 13:35 ` [PATCH 03/12] drm/cirrus: do not disable outputs on fbdev init for atomic Varad Gautam
2017-09-08 13:35 ` [PATCH 04/12] drm/cirrus: initialize start and size fields Varad Gautam
2017-09-11 8:23 ` Gerd Hoffmann
2017-09-08 13:35 ` Varad Gautam [this message]
2017-09-11 8:31 ` [PATCH 05/12] drm/cirrus: hardcode vram size Gerd Hoffmann
2017-09-08 13:35 ` [PATCH 06/12] drm/cirrus: implement PRIME export for cirrus Varad Gautam
2017-09-08 13:35 ` [PATCH 07/12] drm/cirrus: use universal plane interfaces for primary plane Varad Gautam
2017-09-08 13:35 ` [PATCH 08/12] drm/cirrus: use atomic transition helpers for plane and crtc Varad Gautam
2017-09-08 13:35 ` [PATCH 09/12] drm/cirrus: send vblank on crtc atomic_flush Varad Gautam
2017-09-08 13:35 ` [PATCH 10/12] drm/cirrus: use atomic handlers for plane and crtc Varad Gautam
2017-09-08 13:35 ` [PATCH 11/12] drm/cirrus: implement atomic hardware cursor support Varad Gautam
2017-09-11 8:37 ` Gerd Hoffmann
2017-09-08 13:35 ` [PATCH 12/12] drm/cirrus: advertise DRIVER_ATOMIC Varad Gautam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170908133517.18715-6-varadgautam@gmail.com \
--to=varadgautam@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=marcheu@chromium.org \
--cc=zachr@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox