From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: "ankit.k.nautiyal@intel.com" <ankit.k.nautiyal@intel.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v3 4/8] drm: Add DRM client cap for aspect-ratio
Date: Thu, 18 Jan 2018 18:04:30 +0200 [thread overview]
Message-ID: <20180118160430.GZ10981@intel.com> (raw)
In-Reply-To: <f6bdb1a5-a17b-a341-33cf-bbe788c32e82@intel.com>
On Thu, Jan 18, 2018 at 09:11:19PM +0530, ankit.k.nautiyal@intel.com wrote:
> Hi Marteen,
>
> Thanks for the review comments. Please find my comments in-line.
>
>
> On Thursday 18 January 2018 03:46 PM, Maarten Lankhorst wrote:
> > Op 12-01-18 om 07:21 schreef Nautiyal, Ankit K:
> >> From: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> >>
> >> A new drm client cap is required to enable user-space to advertise
> >> if it supports modes with aspect-ratio. Based on this cap value, the
> >> kernel will take a call on exposing the aspect ratio information in
> >> modes or not.
> >>
> >> This patch adds the client cap for aspect-ratio.
> >>
> >> Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
> >> Cc: Shashank Sharma <shashank.sharma@intel.com>
> >> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> > What's missing from the commit message is why this needs to be a flag that userspace needs to enable,
> > instead of something that only counts as an informative query.
> >
> > I gathered from danvet that blindly exposing things breaks existing userspace, so could that information be added to the commit?
>
> Agreed. This information indeed brings out the real reason for the patch.
> Will add the details in the commit message in the next patch-set.
>
> >
> > Also missing IGT tests, would be nice we at least get some verification things work as expected.
>
> Currently this is being tested with the corresponding userspace changes
> in weston compositor, but a simple IGT on the same lines of kms_3d
> can be prepared.
A separate test to check that the different aspect ratio modes are
correctly enumerated, and filtered out when the cap is not set seems
like a good idea.
As for actaully testing different aspect ratio modes, maybe just
intergrate that into testdisplay?
--
Ville Syrjälä
Intel OTC
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-01-18 16:04 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-12 6:21 [PATCH v3 0/8] Aspect ratio support in DRM layer Nautiyal, Ankit K
2018-01-12 6:21 ` [PATCH v3 1/8] drm/modes: Introduce drm_mode_match() Nautiyal, Ankit K
2018-01-17 8:41 ` Sharma, Shashank
2018-01-17 15:21 ` Ville Syrjälä
2018-01-18 6:10 ` Sharma, Shashank
2018-01-12 6:21 ` [PATCH v3 2/8] drm/edid: Use drm_mode_match_no_clocks_no_stereo() for consistentcy Nautiyal, Ankit K
2018-01-17 8:53 ` Sharma, Shashank
2018-01-12 6:21 ` [PATCH v3 3/8] drm/edid: Fix cea mode aspect ratio handling Nautiyal, Ankit K
2018-01-17 9:05 ` Sharma, Shashank
2018-01-17 15:29 ` Ville Syrjälä
2018-01-18 6:14 ` Sharma, Shashank
2018-01-12 6:21 ` [PATCH v3 4/8] drm: Add DRM client cap for aspect-ratio Nautiyal, Ankit K
2018-01-17 9:11 ` Sharma, Shashank
2018-01-18 10:16 ` Maarten Lankhorst
2018-01-18 15:41 ` ankit.k.nautiyal
2018-01-18 16:04 ` Ville Syrjälä [this message]
2018-01-19 5:44 ` Nautiyal, Ankit K
2018-01-22 4:34 ` [PATCH v4 " Nautiyal, Ankit K
2018-01-12 6:21 ` [PATCH v3 5/8] drm: Handle aspect ratio info in atomic and legacy modeset paths Nautiyal, Ankit K
2018-01-29 18:53 ` Ville Syrjälä
2018-01-31 6:34 ` Nautiyal, Ankit K
2018-01-31 13:09 ` Ville Syrjälä
2018-02-01 11:05 ` Nautiyal, Ankit K
2018-02-01 12:54 ` Ville Syrjälä
2018-02-08 4:29 ` Nautiyal, Ankit K
2018-02-13 4:51 ` Nautiyal, Ankit K
2018-02-13 13:18 ` Ville Syrjälä
2018-02-13 16:23 ` Nautiyal, Ankit K
2018-02-13 16:45 ` Ville Syrjälä
2018-02-15 11:57 ` Nautiyal, Ankit K
2018-01-12 6:21 ` [PATCH v3 6/8] drm: Expose modes with aspect ratio, only if requested Nautiyal, Ankit K
2018-01-29 18:58 ` Ville Syrjälä
2018-01-31 8:00 ` Nautiyal, Ankit K
2018-01-12 6:21 ` [PATCH v3 7/8] drm: Add aspect ratio parsing in DRM layer Nautiyal, Ankit K
2018-01-12 6:21 ` [PATCH v3 8/8] drm: Add and handle new aspect ratios " Nautiyal, Ankit K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180118160430.GZ10981@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=ankit.k.nautiyal@intel.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox