From: "Sharma, Shashank" <shashank.sharma@intel.com>
To: "Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v3 2/8] drm/edid: Use drm_mode_match_no_clocks_no_stereo() for consistentcy
Date: Wed, 17 Jan 2018 14:23:40 +0530 [thread overview]
Message-ID: <f18ae2df-9e15-e69e-a675-a366cf05d822@intel.com> (raw)
In-Reply-To: <1515738096-16892-3-git-send-email-ankit.k.nautiyal@intel.com>
Regards
Shashank
On 1/12/2018 11:51 AM, Nautiyal, Ankit K wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Use drm_mode_equal_no_clocks_no_stereo() in
> drm_match_hdmi_mode_clock_tolerance() for consistency as we
> also use it in drm_match_hdmi_mode() and the cea mode matching
> functions.
>
> This doesn't actually change anything since the input mode
> comes from detailed timings and we match it against
> edid_4k_modes[] which. So none of those modes can have stereo
> flags set.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/drm_edid.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> index ddd5379..1818a71 100644
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -3025,7 +3025,7 @@ static u8 drm_match_hdmi_mode_clock_tolerance(const struct drm_display_mode *to_
> abs(to_match->clock - clock2) > clock_tolerance)
> continue;
>
> - if (drm_mode_equal_no_clocks(to_match, hdmi_mode))
> + if (drm_mode_equal_no_clocks_no_stereo(to_match, hdmi_mode))
> return vic;
> }
Reviewed-by: Shashank Sharma <shashank.sharma@intel.com>
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-01-17 8:53 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-12 6:21 [PATCH v3 0/8] Aspect ratio support in DRM layer Nautiyal, Ankit K
2018-01-12 6:21 ` [PATCH v3 1/8] drm/modes: Introduce drm_mode_match() Nautiyal, Ankit K
2018-01-17 8:41 ` Sharma, Shashank
2018-01-17 15:21 ` Ville Syrjälä
2018-01-18 6:10 ` Sharma, Shashank
2018-01-12 6:21 ` [PATCH v3 2/8] drm/edid: Use drm_mode_match_no_clocks_no_stereo() for consistentcy Nautiyal, Ankit K
2018-01-17 8:53 ` Sharma, Shashank [this message]
2018-01-12 6:21 ` [PATCH v3 3/8] drm/edid: Fix cea mode aspect ratio handling Nautiyal, Ankit K
2018-01-17 9:05 ` Sharma, Shashank
2018-01-17 15:29 ` Ville Syrjälä
2018-01-18 6:14 ` Sharma, Shashank
2018-01-12 6:21 ` [PATCH v3 4/8] drm: Add DRM client cap for aspect-ratio Nautiyal, Ankit K
2018-01-17 9:11 ` Sharma, Shashank
2018-01-18 10:16 ` Maarten Lankhorst
2018-01-18 15:41 ` ankit.k.nautiyal
2018-01-18 16:04 ` Ville Syrjälä
2018-01-19 5:44 ` Nautiyal, Ankit K
2018-01-22 4:34 ` [PATCH v4 " Nautiyal, Ankit K
2018-01-12 6:21 ` [PATCH v3 5/8] drm: Handle aspect ratio info in atomic and legacy modeset paths Nautiyal, Ankit K
2018-01-29 18:53 ` Ville Syrjälä
2018-01-31 6:34 ` Nautiyal, Ankit K
2018-01-31 13:09 ` Ville Syrjälä
2018-02-01 11:05 ` Nautiyal, Ankit K
2018-02-01 12:54 ` Ville Syrjälä
2018-02-08 4:29 ` Nautiyal, Ankit K
2018-02-13 4:51 ` Nautiyal, Ankit K
2018-02-13 13:18 ` Ville Syrjälä
2018-02-13 16:23 ` Nautiyal, Ankit K
2018-02-13 16:45 ` Ville Syrjälä
2018-02-15 11:57 ` Nautiyal, Ankit K
2018-01-12 6:21 ` [PATCH v3 6/8] drm: Expose modes with aspect ratio, only if requested Nautiyal, Ankit K
2018-01-29 18:58 ` Ville Syrjälä
2018-01-31 8:00 ` Nautiyal, Ankit K
2018-01-12 6:21 ` [PATCH v3 7/8] drm: Add aspect ratio parsing in DRM layer Nautiyal, Ankit K
2018-01-12 6:21 ` [PATCH v3 8/8] drm: Add and handle new aspect ratios " Nautiyal, Ankit K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f18ae2df-9e15-e69e-a675-a366cf05d822@intel.com \
--to=shashank.sharma@intel.com \
--cc=ankit.k.nautiyal@intel.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox