dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Gray <jsg@jsg.id.au>
To: Eric Engestrom <eric.engestrom@imgtec.com>
Cc: kettenis@openbsd.org, matthieu@openbsd.org,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH libdrm] configure.ac: pthread-stubs not present on OpenBSD
Date: Wed, 21 Feb 2018 00:14:30 +1100	[thread overview]
Message-ID: <20180220131430.GC55811@largo.jsg.id.au> (raw)
In-Reply-To: <20180220121845.6ba6y57vuvrc7es3@imgtec.com>

On Tue, Feb 20, 2018 at 12:18:45PM +0000, Eric Engestrom wrote:
> On Tuesday, 2018-02-20 22:23:41 +1100, Jonathan Gray wrote:
> > On Tue, Feb 20, 2018 at 10:21:38AM +0000, Eric Engestrom wrote:
> > > On Tuesday, 2018-02-20 17:09:14 +1100, Jonathan Gray wrote:
> > > > pthread-stubs is no longer required on OpenBSD and has been removed.
> > > > libpthread parts involved moved to libc.
> > > 
> > > Great news!
> > > Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com>
> > > 
> > > Note that meson needs the same change:
> > > ----8<----
> > > diff --git a/meson.build b/meson.build
> > > index d600a906948c0e680885..bd00cdc2cae9f0749180 100644
> > > --- a/meson.build
> > > +++ b/meson.build
> > > @@ -35,8 +35,7 @@ with_install_tests = get_option('install-test-programs')
> > >  
> > >  config = configuration_data()
> > >  
> > > -# TODO: openbsd is guess, the others are correct
> > > -if ['freebsd', 'dragonfly', 'netbsd', 'openbsd'].contains(host_machine.system())
> > > +if ['freebsd', 'dragonfly', 'netbsd'].contains(host_machine.system())
> > >    dep_pthread_stubs = dependency('pthread-stubs', version : '>= 0.4')
> > >  else
> > >    dep_pthread_stubs = []
> > > ---->8----
> > > 
> > > Do you have commit access, or do you want me to push this for you?
> > > No need to send a v2, I'll add the meson bit when I push it, or you can
> > > add it if you push it yourself.
> > 
> > An almost identical patch was sent to the Mesa list.  I don't have
> > commit access to either repository so if you could push it that would be
> > great.
> 
> Saw it and it is also r-b'ed; I'll push them later today :)
> 
> > 
> > We can't take a build dependency on python for the xserver and related
> > parts in OpenBSD so I have no interest in meson and very much hope
> > autoconf remains otherwise it is back to writing custom makefiles for
> > everything.
> 
> Hmm, the idea was to get rid of autotools when the meson.build files
> have been tested enough, which sounds like it will be an issue for you.
> 
> What exactly is the blocker to using Meson on your side? Is it something
> that just needs a bit of work, or something that can't be done because of
> external factors (eg. some "scripting languages are not allowed" rule)?
> You mention python, would a Meson implementation in an other language be
> better for you guys?

It has been mentioned in several places at various times by
Matthieu Herrb, Mark Kettenis and myself.

ie
https://lists.x.org/archives/xorg-devel/2018-February/055807.html
https://lists.x.org/archives/xorg-devel/2017-March/053195.html
https://lists.freedesktop.org/archives/dri-devel/2017-March/135935.html

The OpenBSD src and xenocara trees need to be self-contained.  For
autotools we can regenerate files after import and not have a build time
dependency on gnu tools or ports.

Even if there was a C or perl implementation of meson under a suitable
license (not apache 2.0) it would still have to be integrated into a
make based build.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2018-02-20 13:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-20  6:09 [PATCH libdrm] configure.ac: pthread-stubs not present on OpenBSD Jonathan Gray
2018-02-20 10:21 ` Eric Engestrom
2018-02-20 11:23   ` Jonathan Gray
2018-02-20 12:18     ` Eric Engestrom
2018-02-20 13:14       ` Jonathan Gray [this message]
2018-02-20 15:02   ` Emil Velikov
2018-02-20 15:12     ` Eric Engestrom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180220131430.GC55811@largo.jsg.id.au \
    --to=jsg@jsg.id.au \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=eric.engestrom@imgtec.com \
    --cc=kettenis@openbsd.org \
    --cc=matthieu@openbsd.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox