Re: [PATCH libdrm] configure.ac: pthread-stubs not present on OpenBSD

[Eric Engestrom <eric.engestrom@imgtec.com>]

On Tuesday, 2018-02-20 15:02:26 +0000, Emil Velikov wrote:
> On 20 February 2018 at 10:21, Eric Engestrom <eric.engestrom@imgtec.com> wrote:
> > On Tuesday, 2018-02-20 17:09:14 +1100, Jonathan Gray wrote:
> >> pthread-stubs is no longer required on OpenBSD and has been removed.
> >> libpthread parts involved moved to libc.
> >
> > Great news!
> > Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com>
> >
> > Note that meson needs the same change:
> > ----8<----
> > diff --git a/meson.build b/meson.build
> > index d600a906948c0e680885..bd00cdc2cae9f0749180 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -35,8 +35,7 @@ with_install_tests = get_option('install-test-programs')
> >
> >  config = configuration_data()
> >
> > -# TODO: openbsd is guess, the others are correct
> > -if ['freebsd', 'dragonfly', 'netbsd', 'openbsd'].contains(host_machine.system())
> > +if ['freebsd', 'dragonfly', 'netbsd'].contains(host_machine.system())
> >    dep_pthread_stubs = dependency('pthread-stubs', version : '>= 0.4')
> >  else
> >    dep_pthread_stubs = []
> > ---->8----
> >
> > Do you have commit access, or do you want me to push this for you?
> > No need to send a v2, I'll add the meson bit when I push it, or you can
> > add it if you push it yourself.
> >
> Both patches from Jon + the meson amendment are
> Reviewed-by: Emil Velikov <emil.velikov@collabora.com>

... and pushed both, thanks :)

> 
> -Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel