From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: Dave Airlie <airlied@redhat.com>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 3/5] drm/armada: Construct a temporary crtc state for plane checks
Date: Fri, 23 Feb 2018 17:55:47 +0200 [thread overview]
Message-ID: <20180223155547.GP5453@intel.com> (raw)
In-Reply-To: <20180202151054.GB5453@intel.com>
On Fri, Feb 02, 2018 at 05:10:54PM +0200, Ville Syrjälä wrote:
> On Fri, Feb 02, 2018 at 04:10:39PM +0200, Ville Syrjälä wrote:
> > On Tue, Jan 23, 2018 at 09:02:35PM +0200, Ville Syrjälä wrote:
> > > On Tue, Jan 23, 2018 at 06:42:00PM +0000, Russell King - ARM Linux wrote:
> > > > On Tue, Jan 23, 2018 at 07:08:55PM +0200, Ville Syrjala wrote:
> > > > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > > >
> > > > > As armada isn't an atomic driver trying to pass a non-populated
> > > > > crtc->state to drm_atomic_helper_check_plane_state() will end in tears.
> > > > > Construct a temporary crtc state a la drm_plane_helper_check_update()
> > > > > and pass that instead. For now we just really need crtc_state->enable
> > > > > to be there.
> > > >
> > > > Would it be possible to solve this by having the atomic state setup
> > > > for non-atomic drivers instead, so we're not unwinding some of the
> > > > work that's already been done to try and convert drivers /to/
> > > > atomic modeset?
> > >
> > > Dunno. Feels like a wasted effort adding more code that'll just get
> > > ripped out as soon as the atomic conversion happens. And I'd rather
> > > not have to worry about potentially stale states hanging around, in
> > > case you forgot to update something somewhere.
> > >
> > > In any case, I don't think this is unwinding anything. Once you have
> > > the atomic conversion done sufficiently you can just drop these
> > > temporary states. We already have the temp state for the plane here
> > > anyway, and pairing that with a crtc state seems rather logical.
> >
> > So yea or nay on these armada patches?
>
> Also cc:ing Lucas since apparently armada is somehow related to
> etnaviv...
>
> I have my doubts about the current code working at all (due to
> the conflict resolution between my refactoring and rmk's work).
Ping. I'd like to get the final piece merged at some point. armada
is holding that back.
--
Ville Syrjälä
Intel OTC
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-02-23 15:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 17:08 [PATCH 1/5] drm/rcar-du: Use drm_mode_get_hv_timing() to populate plane clip rectangle Ville Syrjala
2018-01-23 17:08 ` [PATCH 2/5] drm/sun4i: " Ville Syrjala
2018-02-02 15:04 ` Ville Syrjälä
2018-01-23 17:08 ` [PATCH 3/5] drm/armada: Construct a temporary crtc state for plane checks Ville Syrjala
2018-01-23 18:42 ` Russell King - ARM Linux
2018-01-23 19:02 ` Ville Syrjälä
2018-02-02 14:10 ` Ville Syrjälä
2018-02-02 15:10 ` Ville Syrjälä
2018-02-23 15:55 ` Ville Syrjälä [this message]
2018-02-23 19:14 ` Russell King - ARM Linux
2018-01-23 17:08 ` [PATCH 4/5] drm/armada: Use drm_mode_get_hv_timing() to populate plane clip rectangle Ville Syrjala
2018-03-05 8:41 ` Daniel Vetter
2018-03-05 18:58 ` Ville Syrjälä
2018-01-23 17:08 ` [PATCH 5/5] drm: Don't pass clip to drm_atomic_helper_check_plane_state() Ville Syrjala
[not found] ` <20180123170857.13818-5-ville.syrjala-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2018-01-23 17:46 ` Liviu Dudau
2018-01-26 5:23 ` Neil Armstrong
2018-01-23 18:06 ` Philipp Zabel
2018-01-24 0:12 ` Laurent Pinchart
2018-01-24 19:48 ` Sinclair Yeh
2018-02-05 6:50 ` Shawn Guo
2018-01-24 0:07 ` [PATCH 1/5] drm/rcar-du: Use drm_mode_get_hv_timing() to populate plane clip rectangle Laurent Pinchart
2018-01-24 15:01 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180223155547.GP5453@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox