From: Sean Paul <seanpaul@chromium.org>
To: Daniele Castagna <dcastagna@chromium.org>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 10/10] drm/rockchip: Enable 'PLANE_CTM' drm property.
Date: Tue, 27 Feb 2018 11:10:27 -0500 [thread overview]
Message-ID: <20180227161027.GJ223881@art_vandelay> (raw)
In-Reply-To: <20180215053300.70482-11-dcastagna@chromium.org>
On Thu, Feb 15, 2018 at 12:33:00AM -0500, Daniele Castagna wrote:
> Enable and expose 'PLANE_CTM' matrix on primary and overaly planes.
> The property can be use to set a RGB to RGB 3X3 color conversion
> matrix that will be applied to planes at scanout.
>
> Change-Id: Ifb7a680ab84c17557b8b3c5aaba1aa3b4eecfcaa
Once you add the missing SoB,
Reviewed-by: Sean Paul <seanpaul@chromium.org>
> ---
> drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> index 8c8118c3db308..4148e2b025b31 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> @@ -1352,6 +1352,9 @@ static int vop_create_crtc(struct vop *vop)
>
> ret = drm_crtc_init_with_planes(drm_dev, crtc, primary, cursor,
> &vop_crtc_funcs, NULL);
> +
> + drm_plane_enable_color_mgmt(primary, 0, true, 0);
> +
> if (ret)
> goto err_cleanup_planes;
>
> @@ -1381,6 +1384,8 @@ static int vop_create_crtc(struct vop *vop)
> goto err_cleanup_crtc;
> }
> drm_plane_helper_add(&vop_win->base, &plane_helper_funcs);
> +
> + drm_plane_enable_color_mgmt(&vop_win->base, 0, true, 0);
> }
>
> port = of_get_child_by_name(dev->of_node, "port");
> --
> 2.16.1.291.g4437f3f132-goog
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-02-27 16:10 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-15 5:32 [PATCH 00/10] drm: Add plane color matrix on rockchip Daniele Castagna
2018-02-15 5:32 ` [PATCH 01/10] drm/rockchip: YUV overlays BT.601 color conversion Daniele Castagna
2018-02-16 17:55 ` kbuild test robot
2018-02-27 15:03 ` Sean Paul
2018-12-14 16:29 ` [PATCH v2] drm/rockchip: Fix YUV buffers color rendering Ezequiel Garcia
2019-01-03 16:28 ` Ezequiel Garcia
2019-01-07 13:26 ` Heiko Stuebner
2019-01-07 20:07 ` Ezequiel Garcia
2019-01-08 17:17 ` Ezequiel Garcia
2019-01-08 21:46 ` [PATCH v3] " Ezequiel Garcia
2019-01-10 22:55 ` Heiko Stuebner
2018-02-15 5:32 ` [PATCH 02/10] drm: Add Plane Degamma properties Daniele Castagna
2018-02-16 19:38 ` kbuild test robot
2018-02-19 15:15 ` Daniel Vetter
2018-02-27 15:13 ` Sean Paul
2018-02-28 14:54 ` Shankar, Uma
2018-02-15 5:32 ` [PATCH 03/10] drm: Add Plane CTM property Daniele Castagna
2018-02-27 15:22 ` Sean Paul
2018-02-28 14:55 ` Shankar, Uma
2018-02-15 5:32 ` [PATCH 04/10] drm: Add Plane Gamma properties Daniele Castagna
2018-02-15 19:29 ` Harry Wentland
2018-02-15 19:45 ` Daniele Castagna
2018-02-16 20:10 ` Ville Syrjälä
2018-02-16 21:36 ` Harry Wentland
2018-02-18 6:43 ` Shankar, Uma
2018-02-19 15:14 ` Daniel Vetter
2018-02-27 15:26 ` Sean Paul
2018-02-27 16:52 ` Ville Syrjälä
2018-02-15 5:32 ` [PATCH 05/10] drm: Define helper function for plane color enabling Daniele Castagna
2018-02-27 15:28 ` Sean Paul
2018-02-28 14:57 ` Shankar, Uma
2018-02-15 5:32 ` [PATCH 06/10] drm: Define helper to set legacy gamma table size Daniele Castagna
2018-02-16 22:17 ` kbuild test robot
2018-02-27 15:35 ` Sean Paul
2018-02-27 16:20 ` Emil Velikov
2018-02-15 5:32 ` [PATCH 07/10] drm/rockchip: Add yuv2yuv registers to vop_lit Daniele Castagna
2018-02-27 15:36 ` Sean Paul
2018-02-15 5:32 ` [PATCH 08/10] drm/rockchip: Add R2R registers Daniele Castagna
2018-02-27 15:41 ` Sean Paul
2018-02-15 5:32 ` [PATCH 09/10] drm/rockchip: Implement drm plane->ctm property Daniele Castagna
2018-02-27 16:09 ` Sean Paul
2018-02-15 5:33 ` [PATCH 10/10] drm/rockchip: Enable 'PLANE_CTM' drm property Daniele Castagna
2018-02-27 16:10 ` Sean Paul [this message]
2018-02-19 15:16 ` [PATCH 00/10] drm: Add plane color matrix on rockchip Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180227161027.GJ223881@art_vandelay \
--to=seanpaul@chromium.org \
--cc=dcastagna@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox