From: Thierry Reding <thierry.reding@gmail.com>
To: Jyri Sarha <jsarha@ti.com>
Cc: airlied@linux.ie, tomi.valkeinen@ti.com, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 1/2] drm/panel: Remove drm_panel_detach() calls from all panel drives
Date: Wed, 28 Feb 2018 19:53:00 +0100 [thread overview]
Message-ID: <20180228185259.GB22932@mithrandir> (raw)
In-Reply-To: <94922d2b5feed117354b5c0a42b4b56f643f73d9.1519815150.git.jsarha@ti.com>
[-- Attachment #1.1: Type: text/plain, Size: 1287 bytes --]
On Wed, Feb 28, 2018 at 01:09:29PM +0200, Jyri Sarha wrote:
> Setting the connector and drm to NULL when the drm panel device is
> going away hardly serves any purpose. Usually the the whole memory
> stucture is freed right after the remove call.
>
> Signed-off-by: Jyri Sarha <jsarha@ti.com>
> ---
> drivers/gpu/drm/panel/panel-innolux-p079zca.c | 1 -
> drivers/gpu/drm/panel/panel-jdi-lt070me05000.c | 1 -
> drivers/gpu/drm/panel/panel-lvds.c | 1 -
> drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c | 1 -
> drivers/gpu/drm/panel/panel-seiko-43wvf1g.c | 1 -
> drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c | 1 -
> drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c | 1 -
> drivers/gpu/drm/panel/panel-simple.c | 1 -
> drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 1 -
> 9 files changed, 9 deletions(-)
I don't understand the purpose of this patch. I'll grant you that the
current implementation of drm_panel_detach() is not very useful, but
then you add code to drm_panel_detach() in the next patch and mention
in the commit message that panel drivers should be calling the
drm_panel_detach() function to remove the link.
This is confusing. Can you clarify?
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-02-28 19:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 11:09 [PATCH v2 0/2] drm/panel: Add device link in drm_panel_attach() Jyri Sarha
2018-02-28 11:09 ` [PATCH v2 1/2] drm/panel: Remove drm_panel_detach() calls from all panel drives Jyri Sarha
2018-02-28 18:53 ` Thierry Reding [this message]
2018-02-28 21:31 ` Jyri Sarha
2018-03-06 10:03 ` Daniel Vetter
2018-02-28 11:09 ` [PATCH v2 2/2] drm/panel: Add device_link from panel device to drm device Jyri Sarha
2018-02-28 18:14 ` Eric Anholt
2018-03-01 17:53 ` Jyri Sarha
2018-02-28 19:32 ` Lukas Wunner
2018-02-28 19:47 ` [PATCH v2 0/2] drm/panel: Add device link in drm_panel_attach() Lukas Wunner
2018-03-01 17:42 ` Jyri Sarha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180228185259.GB22932@mithrandir \
--to=thierry.reding@gmail.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=jsarha@ti.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox