From: Eric Anholt <eric@anholt.net>
To: dri-devel@lists.freedesktop.org
Cc: airlied@linux.ie, tomi.valkeinen@ti.com,
thierry.reding@gmail.com, Jyri Sarha <jsarha@ti.com>
Subject: Re: [PATCH v2 2/2] drm/panel: Add device_link from panel device to drm device
Date: Wed, 28 Feb 2018 10:14:20 -0800 [thread overview]
Message-ID: <87tvu1f0cj.fsf@anholt.net> (raw)
In-Reply-To: <d6bb7a8900d9a701ae13a3d0fa2c34b01089038f.1519815150.git.jsarha@ti.com>
[-- Attachment #1.1: Type: text/plain, Size: 1003 bytes --]
Jyri Sarha <jsarha@ti.com> writes:
> Add device_link from panel device (supplier) to drm device (consumer)
> with DL_FLAG_AUTOREMOVE when drm_panel_attach() is called. Currently
> the master drm driver is not protected against the attached. The
> device_link with DL_FLAG_AUTOREMOVE should make sure the drm device is
> unbound before the panel driver becomes unavailable.
>
> The device_link is removed when drm_panel_detach() is called. The
> drm_panel_detach() should be called by the panel driver it self when
> it is removed. Otherwise the both driver are racing to delete the same
> link.
I think this paragraph wants to be:
The device_link is removed when drm_panel_detach() is called. The
drm_panel_detach() should be called by the consumer DRM driver, not the
panel driver, otherwise both drivers are racing to delete the same link.
Other than that, these patches are:
Reviewed-by: Eric Anholt <eric@anholt.net>
(though you'll probably want to wait a bit for Thierry to look at them
too)
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-02-28 18:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 11:09 [PATCH v2 0/2] drm/panel: Add device link in drm_panel_attach() Jyri Sarha
2018-02-28 11:09 ` [PATCH v2 1/2] drm/panel: Remove drm_panel_detach() calls from all panel drives Jyri Sarha
2018-02-28 18:53 ` Thierry Reding
2018-02-28 21:31 ` Jyri Sarha
2018-03-06 10:03 ` Daniel Vetter
2018-02-28 11:09 ` [PATCH v2 2/2] drm/panel: Add device_link from panel device to drm device Jyri Sarha
2018-02-28 18:14 ` Eric Anholt [this message]
2018-03-01 17:53 ` Jyri Sarha
2018-02-28 19:32 ` Lukas Wunner
2018-02-28 19:47 ` [PATCH v2 0/2] drm/panel: Add device link in drm_panel_attach() Lukas Wunner
2018-03-01 17:42 ` Jyri Sarha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvu1f0cj.fsf@anholt.net \
--to=eric@anholt.net \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=jsarha@ti.com \
--cc=thierry.reding@gmail.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox