From: Manasi Navare <manasi.d.navare@intel.com>
To: Harry Wentland <harry.wentland@amd.com>
Cc: "Keith Packard" <keithp@keithp.com>,
"Nicolai Hähnle" <nicolai.haehnle@amd.com>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Michel Dänzer" <michel@daenzer.net>,
"Michel Dänzer" <michel.daenzer@amd.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
"amd-gfx mailing list" <amd-gfx@lists.freedesktop.org>,
"Deucher, Alexander" <Alexander.Deucher@amd.com>,
"Koo, Anthony" <Anthony.Koo@amd.com>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: RFC for a render API to support adaptive sync and VRR
Date: Mon, 23 Apr 2018 14:19:44 -0700 [thread overview]
Message-ID: <20180423211944.GC9472@intel.com> (raw)
In-Reply-To: <488ba81c-9a40-77d3-fb71-ee0df7f9b42f@amd.com>
On Mon, Apr 23, 2018 at 10:40:06AM -0400, Harry Wentland wrote:
> On 2018-04-20 04:32 PM, Manasi Navare wrote:
> > On Wed, Apr 18, 2018 at 09:39:02AM +0200, Daniel Vetter wrote:
> >> On Wed, Apr 18, 2018 at 5:58 AM, Keith Packard <keithp@keithp.com> wrote:
> >>> Michel Dänzer <michel@daenzer.net> writes:
> >>>> Time-based presentation seems to be the right approach for preventing
> >>>> micro-stutter in games as well, Croteam developers have been researching
> >>>> this.
> >>>
> >>> Both the Vulkan GOOGLE_display_timing extension and X11 Present
> >>> extension offer the ability to specify the desired display time in
> >>> seconds.
> >>>
> >>> Similarly, I'd suggest that the min/max display refresh rate values be
> >>> advertised as time between frames rather than frames per second.
> >
> > So there is a global min and max refresh rate as advertised by the monitor
> > range descriptor. That I guess can be exposed as a global range in terms of
> > min and max time between frames as a global property of the connector.
> >
> > We dont need the per mode min and max refresh rate to be exposed right?
>
> If I understand VRR right, with CinemaVRR acceptable refresh rates might fall outside the range advertised by the monitor. Would we
> 1) advertise 24/1.001 as a lower bound,
> 2) expect media apps to use the lower bound simply for informational purposes,
> 3) or simply not support CinemaVRR?
>
> (1) has the added caveat that not all reported rates would be supported.
>
> Alternatively a bit could indicate that CinemaVRR is support, but I'm not sure if user mode would need all these details.
>
> Harry
Are there special CinemaVRR suported monitors? In that case we need to understand how those monitors
advertise the monitor range and if they have a bit in EDID that indicate they are CinemaVRR capable
as opposed to just the Adaptive Sync/VRR.
Harry, if you have one of those monitors, could you send the EDID dump for that?
Manasi
>
> >
> >>>
> >>> I'd also encourage using a single unit for all of these values,
> >>> preferably nanoseconds. Absolute times should all be referenced to
> >>> CLOCK_MONOTONIC.
> >>
> >> +1 on everything Keith said. I got somehow dragged in khr vk
> >> discussions around preventing micro-stuttering, and consensus seems to
> >> be that timestamps for scheduling frames is the way to go, most likely
> >> absolute ones (not everything is running Linux unfortunately, so can't
> >> go outright and claim it's guaranteed to be CLOCK_MONOTONIC).
> >> -Daniel
> >
> > And yes I also got consensus from Mesa and media folks about using the
> > absolute timestamp for scheduling the frames and then the driver will
> > modify the vblank logic to "present no earlier than the timestamp"
> >
> > Manasi
> >
> >> --
> >> Daniel Vetter
> >> Software Engineer, Intel Corporation
> >> +41 (0) 79 365 57 48 - http://blog.ffwll.ch
> >> _______________________________________________
> >> dri-devel mailing list
> >> dri-devel@lists.freedesktop.org
> >> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> >
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-04-23 21:19 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <c79421ce-9408-5cd6-5de3-0fa521146e4b@amd.com>
[not found] ` <c79421ce-9408-5cd6-5de3-0fa521146e4b-5C7GfCeVMHo@public.gmane.org>
2018-04-09 20:00 ` RFC for a render API to support adaptive sync and VRR Harry Wentland
[not found] ` <435ebd04-0435-5a6a-9f1e-e4c4fc629aa9-5C7GfCeVMHo@public.gmane.org>
2018-04-09 21:45 ` Manasi Navare
[not found] ` <20180409214554.GB13967-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2018-04-10 6:45 ` Christian König
2018-04-10 7:37 ` Michel Dänzer
[not found] ` <b75e31f7-ce59-de97-5445-cb4c03ff7336-otUistvHUpPR7s880joybQ@public.gmane.org>
2018-04-10 15:08 ` Harry Wentland
[not found] ` <ae9992e5-43ab-9636-13e1-8a5c692480b5-5C7GfCeVMHo@public.gmane.org>
2018-04-10 15:28 ` Christian König
2018-04-10 15:35 ` Cyr, Aric
2018-04-10 15:43 ` Christian König
[not found] ` <fc53ce53-f02c-891d-4aa5-e9a11cbe3007-5C7GfCeVMHo@public.gmane.org>
2018-04-10 16:26 ` Cyr, Aric
[not found] ` <MWHPR12MB1837488A047C03E955282A4182BE0-Gy0DoCVfaSXe1Hf+mWOIywdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2018-04-10 16:37 ` Nicolai Hähnle
[not found] ` <54baa87e-33a9-bd69-a309-d61176eb4e8d-5C7GfCeVMHo@public.gmane.org>
2018-04-10 17:52 ` Harry Wentland
[not found] ` <063d6dff-2b97-ef01-12bb-8a24125a58ec@daenzer.net>
2018-04-10 17:13 ` Cyr, Aric
[not found] ` <65006f34-39b9-5aca-e0c0-77a591b69c3a@daenzer.net>
[not found] ` <65006f34-39b9-5aca-e0c0-77a591b69c3a-otUistvHUpPR7s880joybQ@public.gmane.org>
2018-04-10 17:25 ` Cyr, Aric
[not found] ` <f85e3590-b283-843b-12d0-5f6f0c4c0952@amd.com>
2018-04-10 21:45 ` Cyr, Aric
2018-04-11 6:57 ` Nicolai Hähnle
[not found] ` <72c1d357-db72-b181-9421-04f99b3bbf2f-5C7GfCeVMHo@public.gmane.org>
2018-04-11 9:50 ` Michel Dänzer
[not found] ` <2005817c-09c0-aebe-bb96-9e22d6f16df5-otUistvHUpPR7s880joybQ@public.gmane.org>
2018-04-11 23:30 ` Cyr, Aric
[not found] ` <MWHPR12MB1837F8120B126FA3A4CE899982BD0-Gy0DoCVfaSXe1Hf+mWOIywdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2018-04-12 8:48 ` Michel Dänzer
2018-04-12 11:39 ` Nicolai Hähnle
[not found] ` <a5b5c31f-e7c5-8ae0-1239-06bfa86b939b-5C7GfCeVMHo@public.gmane.org>
2018-04-12 14:57 ` Michel Dänzer
2018-04-12 17:39 ` Harry Wentland
2018-04-11 10:28 ` Michel Dänzer
2018-04-11 15:45 ` Michel Dänzer
[not found] ` <MWHPR12MB1837C57016A470A5199E855282BE0-Gy0DoCVfaSXe1Hf+mWOIywdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2018-04-10 17:13 ` Michel Dänzer
2018-04-12 21:38 ` Stéphane Marchesin
2018-04-13 19:24 ` Harry Wentland
2018-04-18 3:58 ` Keith Packard
2018-04-18 7:39 ` Daniel Vetter
2018-04-20 20:32 ` Manasi Navare
[not found] ` <20180420203240.GA9472-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2018-04-21 10:30 ` Daniel Stone
2018-04-23 14:40 ` Harry Wentland
2018-04-23 21:19 ` Manasi Navare [this message]
[not found] ` <20180423211944.GC9472-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2018-04-24 12:09 ` Daniel Vetter
2018-04-24 14:20 ` Cyr, Aric
[not found] ` <20180424120946.GW31310-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2018-04-24 14:28 ` Harry Wentland
[not found] ` <b9c33eeb-1db8-f782-cfbe-411d94fecb67-5C7GfCeVMHo@public.gmane.org>
2018-04-24 21:57 ` Daniel Vetter
[not found] ` <CAKMK7uHzLRUwZSFbMb4qDzXBODVSQVTTw6BxgmvJdES4gJmBDg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-08-17 10:20 ` Ernst Sjöstrand
2018-04-10 15:03 ` Harry Wentland
2018-04-10 21:36 ` Manasi Navare
2018-04-10 22:00 ` Cyr, Aric
2018-04-13 16:04 ` Daniel Vetter
[not found] ` <20180413160453.GC31310-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2018-04-13 19:20 ` Harry Wentland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180423211944.GC9472@intel.com \
--to=manasi.d.navare@intel.com \
--cc=Alexander.Deucher@amd.com \
--cc=Anthony.Koo@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=keithp@keithp.com \
--cc=michel.daenzer@amd.com \
--cc=michel@daenzer.net \
--cc=nicolai.haehnle@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox