From: Haneen Mohammed <hamohammed.sa@gmail.com>
To: kbuild test robot <lkp@intel.com>
Cc: rodrigosiqueiramelo@gmail.com, daniel.vetter@ffwll.ch,
dri-devel@lists.freedesktop.org, kbuild-all@01.org
Subject: Re: [RFC PATCH] drm/vkms: vkms_driver can be static
Date: Tue, 15 May 2018 18:39:12 +0300 [thread overview]
Message-ID: <20180515153912.GA18534@haneen-vb> (raw)
In-Reply-To: <20180515113052.GA111532@lkp-ib04>
On Tue, May 15, 2018 at 07:30:52PM +0800, kbuild test robot wrote:
>
> Fixes: 58d8108f080c ("drm/vkms: Introduce basic VKMS driver")
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
> vkms_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
> index b1df08e..35517b09 100644
> --- a/drivers/gpu/drm/vkms/vkms_drv.c
> +++ b/drivers/gpu/drm/vkms/vkms_drv.c
> @@ -40,7 +40,7 @@ static void vkms_release(struct drm_device *dev)
> drm_dev_fini(&vkms->drm);
> }
>
> -struct drm_driver vkms_driver = {
> +static struct drm_driver vkms_driver = {
> .driver_features = DRIVER_MODESET | DRIVER_ATOMIC | DRIVER_GEM,
> .release = vkms_release,
> .fops = &vkms_driver_fops,
Looks good to me.
- Haneen
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-05-15 15:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-14 14:33 [PATCH] drm/vkms: Introduce basic VKMS driver Haneen Mohammed
2018-05-15 11:30 ` kbuild test robot
2018-05-15 11:30 ` [RFC PATCH] drm/vkms: vkms_driver can be static kbuild test robot
2018-05-15 15:39 ` Haneen Mohammed [this message]
2018-05-15 17:31 ` Daniel Vetter
2018-05-15 23:43 ` [kbuild-all] " Li, Philip
2018-05-15 11:32 ` [PATCH] drm/vkms: Introduce basic VKMS driver Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180515153912.GA18534@haneen-vb \
--to=hamohammed.sa@gmail.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kbuild-all@01.org \
--cc=lkp@intel.com \
--cc=rodrigosiqueiramelo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox