Re: [RFC PATCH] drm/vkms: vkms_driver can be static

From: Daniel Vetter <daniel@ffwll.ch>
To: kbuild test robot <lkp@intel.com>
Cc: rodrigosiqueiramelo@gmail.com,
	Haneen Mohammed <hamohammed.sa@gmail.com>,
	kbuild-all@01.org, dri-devel@lists.freedesktop.org,
	daniel.vetter@ffwll.ch
Subject: Re: [RFC PATCH] drm/vkms: vkms_driver can be static
Date: Tue, 15 May 2018 19:31:27 +0200	[thread overview]
Message-ID: <20180515173127.GB3438@phenom.ffwll.local> (raw)
In-Reply-To: <20180515113052.GA111532@lkp-ib04>

On Tue, May 15, 2018 at 07:30:52PM +0800, kbuild test robot wrote:
> 
> Fixes: 58d8108f080c ("drm/vkms: Introduce basic VKMS driver")
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

One thing I noticed while applying this: Your author (as recorded in the
From: line) and your s-o-b don't match. Now I know that you're behind
0day, so it's ok, but our script gets annoyed and I need to overrule it
with an -f flag.

Can you perhaps get the From: and S-o-b: lines into agreement so that a
simple comparison works?

Thanks, Daniel

> ---
>  vkms_drv.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
> index b1df08e..35517b09 100644
> --- a/drivers/gpu/drm/vkms/vkms_drv.c
> +++ b/drivers/gpu/drm/vkms/vkms_drv.c
> @@ -40,7 +40,7 @@ static void vkms_release(struct drm_device *dev)
>  	drm_dev_fini(&vkms->drm);
>  }
>  
> -struct drm_driver vkms_driver = {
> +static struct drm_driver vkms_driver = {
>  	.driver_features	= DRIVER_MODESET | DRIVER_ATOMIC | DRIVER_GEM,
>  	.release		= vkms_release,
>  	.fops			= &vkms_driver_fops,

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel