[radeon-alex:drm-next-4.18-wip 114/129] drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:689:6: sparse: symbol 'vcn_v1_0_is_idle' was not declared. Should it be static?

[radeon-alex:drm-next-4.18-wip 114/129] drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:689:6: sparse: symbol 'vcn_v1_0_is_idle' was not declared. Should it be static?

[kbuild test robot]

tree:   git://people.freedesktop.org/~agd5f/linux.git drm-next-4.18-wip
head:   27bd044dd054fed87166c831b6d38bc609e733cc
commit: 9b4c412a654ce71ad0e81044d3300677a7668ac8 [114/129] drm/amdgpu: Add static CG control for VCN on RV
reproduce:
        # apt-get install sparse
        git checkout 9b4c412a654ce71ad0e81044d3300677a7668ac8
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:689:6: sparse: symbol 'vcn_v1_0_is_idle' was not declared. Should it be static?
>> drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:696:5: sparse: symbol 'vcn_v1_0_wait_for_idle' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[RFC PATCH radeon-alex] drm/amdgpu: vcn_v1_0_is_idle() can be static

[kbuild test robot]

Fixes: 9b4c412a654c ("drm/amdgpu: Add static CG control for VCN on RV")
Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
---
 vcn_v1_0.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c
index 7a366418..2b4a789 100644
--- a/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c
@@ -686,14 +686,14 @@ static int vcn_v1_0_stop(struct amdgpu_device *adev)
 	return 0;
 }
 
-bool vcn_v1_0_is_idle(void *handle)
+static bool vcn_v1_0_is_idle(void *handle)
 {
 	struct amdgpu_device *adev = (struct amdgpu_device *)handle;
 
 	return (RREG32_SOC15(VCN, 0, mmUVD_STATUS) == 0x2);
 }
 
-int vcn_v1_0_wait_for_idle(void *handle)
+static int vcn_v1_0_wait_for_idle(void *handle)
 {
 	struct amdgpu_device *adev = (struct amdgpu_device *)handle;
 	int ret = 0;
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel