From: rkir@google.com
To: b.zolnierkie@samsung.com
Cc: Roman Kiryanov <rkir@google.com>,
dri-devel@lists.freedesktop.org, tkjos@google.com
Subject: [PATCH v2 1/3] video: fbdev: Fix checkpatch warnings in goldfishfb.c
Date: Fri, 8 Jun 2018 12:10:58 -0700 [thread overview]
Message-ID: <20180608191100.21751-1-rkir@google.com> (raw)
From: Roman Kiryanov <rkir@google.com>
Address issues pointed by checkpatch.pl
Signed-off-by: Roman Kiryanov <rkir@google.com>
---
Changes in v2:
- Updated the commit message to include "video: fbdev:" and added a description.
drivers/video/fbdev/goldfishfb.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/goldfishfb.c b/drivers/video/fbdev/goldfishfb.c
index 3b70044773b6..de29c4ff77e5 100644
--- a/drivers/video/fbdev/goldfishfb.c
+++ b/drivers/video/fbdev/goldfishfb.c
@@ -124,6 +124,7 @@ static int goldfish_fb_check_var(struct fb_var_screeninfo *var,
static int goldfish_fb_set_par(struct fb_info *info)
{
struct goldfish_fb *fb = container_of(info, struct goldfish_fb, fb);
+
if (fb->rotation != fb->fb.var.rotate) {
info->fix.line_length = info->var.xres * 2;
fb->rotation = fb->fb.var.rotate;
@@ -148,13 +149,14 @@ static int goldfish_fb_pan_display(struct fb_var_screeninfo *var,
wait_event_timeout(fb->wait,
fb->base_update_count != base_update_count, HZ / 15);
if (fb->base_update_count == base_update_count)
- pr_err("goldfish_fb_pan_display: timeout waiting for base update\n");
+ pr_err("%s: timeout waiting for base update\n", __func__);
return 0;
}
static int goldfish_fb_blank(int blank, struct fb_info *info)
{
struct goldfish_fb *fb = container_of(info, struct goldfish_fb, fb);
+
switch (blank) {
case FB_BLANK_NORMAL:
writel(1, fb->reg_base + FB_SET_BLANK);
--
2.18.0.rc1.242.g61856ae69a-goog
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next reply other threads:[~2018-06-08 19:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180608191110epcas5p1a5873d2a43fac1b9530150d9851b227b@epcas5p1.samsung.com>
2018-06-08 19:10 ` rkir [this message]
2018-06-08 19:10 ` [PATCH v2 2/3] video: fbdev: Enable ACPI-based enumeration for goldfishfb rkir
2018-07-03 14:29 ` Bartlomiej Zolnierkiewicz
2018-06-08 19:11 ` [PATCH v2 3/3] video: fbdev: Set pixclock = 0 in goldfishfb rkir
2018-07-03 14:30 ` Bartlomiej Zolnierkiewicz
2018-06-15 23:47 ` [PATCH v2 1/3] video: fbdev: Fix checkpatch warnings in goldfishfb.c Roman Kiryanov
2018-06-18 14:33 ` Bartlomiej Zolnierkiewicz
2018-07-03 14:29 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180608191100.21751-1-rkir@google.com \
--to=rkir@google.com \
--cc=b.zolnierkie@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=tkjos@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox