From: rkir@google.com
To: b.zolnierkie@samsung.com
Cc: Peter Maydell <peter.maydell@linaro.org>,
Roman Kiryanov <rkir@google.com>,
Christoffer Dall <christoffer.dall@linaro.org>,
dri-devel@lists.freedesktop.org, tkjos@google.com
Subject: [PATCH v2 3/3] video: fbdev: Set pixclock = 0 in goldfishfb
Date: Fri, 8 Jun 2018 12:11:00 -0700 [thread overview]
Message-ID: <20180608191100.21751-3-rkir@google.com> (raw)
In-Reply-To: <20180608191100.21751-1-rkir@google.com>
From: Christoffer Dall <christoffer.dall@linaro.org>
User space Android code identifies pixclock == 0 as a sign for emulation
and will set the frame rate to 60 fps when reading this value, which is
the desired outcome.
Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Roman Kiryanov <rkir@google.com>
---
Changes in v2:
- Updated the commit message to include "video: fbdev:".
- Dropped Change-Id.
- Signed-off the commit.
drivers/video/fbdev/goldfishfb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/goldfishfb.c b/drivers/video/fbdev/goldfishfb.c
index 01732858b60d..3a9e5f1b758e 100644
--- a/drivers/video/fbdev/goldfishfb.c
+++ b/drivers/video/fbdev/goldfishfb.c
@@ -237,7 +237,7 @@ static int goldfish_fb_probe(struct platform_device *pdev)
fb->fb.var.activate = FB_ACTIVATE_NOW;
fb->fb.var.height = readl(fb->reg_base + FB_GET_PHYS_HEIGHT);
fb->fb.var.width = readl(fb->reg_base + FB_GET_PHYS_WIDTH);
- fb->fb.var.pixclock = 10000;
+ fb->fb.var.pixclock = 0;
fb->fb.var.red.offset = 11;
fb->fb.var.red.length = 5;
--
2.18.0.rc1.242.g61856ae69a-goog
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-06-08 19:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180608191110epcas5p1a5873d2a43fac1b9530150d9851b227b@epcas5p1.samsung.com>
2018-06-08 19:10 ` [PATCH v2 1/3] video: fbdev: Fix checkpatch warnings in goldfishfb.c rkir
2018-06-08 19:10 ` [PATCH v2 2/3] video: fbdev: Enable ACPI-based enumeration for goldfishfb rkir
2018-07-03 14:29 ` Bartlomiej Zolnierkiewicz
2018-06-08 19:11 ` rkir [this message]
2018-07-03 14:30 ` [PATCH v2 3/3] video: fbdev: Set pixclock = 0 in goldfishfb Bartlomiej Zolnierkiewicz
2018-06-15 23:47 ` [PATCH v2 1/3] video: fbdev: Fix checkpatch warnings in goldfishfb.c Roman Kiryanov
2018-06-18 14:33 ` Bartlomiej Zolnierkiewicz
2018-07-03 14:29 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180608191100.21751-3-rkir@google.com \
--to=rkir@google.com \
--cc=b.zolnierkie@samsung.com \
--cc=christoffer.dall@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=peter.maydell@linaro.org \
--cc=tkjos@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox