dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Paul <seanpaul@chromium.org>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
	DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 03/15] drm/doc: switch drm_connector_state to inline comments
Date: Thu, 12 Jul 2018 09:54:36 -0400	[thread overview]
Message-ID: <20180712135436.GB20303@art_vandelay> (raw)
In-Reply-To: <20180709084016.23750-4-daniel.vetter@ffwll.ch>

On Mon, Jul 09, 2018 at 10:40:04AM +0200, Daniel Vetter wrote:
> For consistency. Also spelled out the docs for ->best_encoder a bit
> more while at it.
> 
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>

Reviewed-by: Sean Paul <seanpaul@chromium.org>

> ---
>  include/drm/drm_connector.h | 14 ++++++++++----
>  1 file changed, 10 insertions(+), 4 deletions(-)
> 
> diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h
> index ad397dfc042b..6028638f3108 100644
> --- a/include/drm/drm_connector.h
> +++ b/include/drm/drm_connector.h
> @@ -374,12 +374,9 @@ struct drm_tv_connector_state {
>  
>  /**
>   * struct drm_connector_state - mutable connector state
> - * @connector: backpointer to the connector
> - * @best_encoder: can be used by helpers and drivers to select the encoder
> - * @state: backpointer to global drm_atomic_state
> - * @tv: TV connector state
>   */
>  struct drm_connector_state {
> +	/** @connector: backpointer to the connector */
>  	struct drm_connector *connector;
>  
>  	/**
> @@ -390,6 +387,13 @@ struct drm_connector_state {
>  	 */
>  	struct drm_crtc *crtc;
>  
> +	/**
> +	 * @best_encoder:
> +	 *
> +	 * Used by the atomic helpers to select the encoder, through the
> +	 * &drm_connector_helper_funcs.atomic_best_encoder or
> +	 * &drm_connector_helper_funcs.best_encoder callbacks.
> +	 */
>  	struct drm_encoder *best_encoder;
>  
>  	/**
> @@ -398,6 +402,7 @@ struct drm_connector_state {
>  	 */
>  	enum drm_link_status link_status;
>  
> +	/** @state: backpointer to global drm_atomic_state */
>  	struct drm_atomic_state *state;
>  
>  	/**
> @@ -407,6 +412,7 @@ struct drm_connector_state {
>  	 */
>  	struct drm_crtc_commit *commit;
>  
> +	/** @tv: TV connector state */
>  	struct drm_tv_connector_state tv;
>  
>  	/**
> -- 
> 2.18.0
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2018-07-12 13:54 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-09  8:40 [PATCH 00/15] bunch of kerneldocs polish and related cleanup Daniel Vetter
2018-07-09  8:40 ` [PATCH 01/15] drm: move drv test macros out of drmP.h Daniel Vetter
2018-07-12 13:52   ` Sean Paul
2018-07-09  8:40 ` [PATCH 02/15] drm: Drop drmP.h from drm_connector.c Daniel Vetter
2018-07-12 13:53   ` Sean Paul
2018-07-09  8:40 ` [PATCH 03/15] drm/doc: switch drm_connector_state to inline comments Daniel Vetter
2018-07-12 13:54   ` Sean Paul [this message]
2018-07-09  8:40 ` [PATCH 04/15] drm/doc: polish for sturct drm_connector Daniel Vetter
2018-07-12 14:01   ` Sean Paul
2018-07-09  8:40 ` [PATCH 05/15] drm: drop _mode_ from update_edit_property() Daniel Vetter
2018-07-13 14:59   ` Sean Paul
2018-07-13 16:05     ` Daniel Vetter
2018-07-09  8:40 ` [PATCH 06/15] drm: drop _mode_ from drm_mode_connector_attach_encoder Daniel Vetter
2018-07-13 15:01   ` Sean Paul
2018-07-09  8:40 ` [PATCH 07/15] drm: drop _mode_ from remaining connector functions Daniel Vetter
2018-07-13 15:05   ` Sean Paul
2018-07-09  8:40 ` [PATCH 08/15] drm: Switch drm_plane_state to inline kerneldoc style Daniel Vetter
2018-07-13 15:08   ` Sean Paul
2018-07-09  8:40 ` [PATCH 09/15] drm: switch drm_plane to inline comments Daniel Vetter
2018-07-13 15:20   ` Sean Paul
2018-07-09  8:40 ` [PATCH 10/15] drm: drop drmP.h include from drm_plane.c Daniel Vetter
2018-07-13 15:22   ` Sean Paul
2018-07-09  8:40 ` [PATCH 11/15] drm/doc: move struct drm_crtc to in-line comments Daniel Vetter
2018-07-13 15:27   ` Sean Paul
2018-07-09  8:40 ` [PATCH 12/15] drm/doc: Group the fb gem helpers better Daniel Vetter
2018-07-12 12:18   ` Noralf Trønnes
2018-07-09  8:40 ` [PATCH 13/15] drm/doc: Includ drm_of.c helpers Daniel Vetter
2018-07-13 15:28   ` Sean Paul
2018-07-09  8:40 ` [PATCH 14/15] drm/doc: use inline kerneldoc style for drm_crtc_state Daniel Vetter
2018-07-13 15:33   ` Sean Paul
2018-07-09  8:40 ` [PATCH 15/15] drm: drop drmP.h include from drm_crtc.c Daniel Vetter
2018-07-12 13:51   ` Sean Paul
2018-07-13 16:41     ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180712135436.GB20303@art_vandelay \
    --to=seanpaul@chromium.org \
    --cc=daniel.vetter@ffwll.ch \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox