From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Jernej Skrabec <jernej.skrabec@siol.net>,
Arnd Bergmann <arnd@arndb.de>,
Naresh Kamboju <naresh.kamboju@linaro.org>,
dri-devel@lists.freedesktop.org,
Jon Hunter <jonathanh@nvidia.com>, Chen-Yu Tsai <wens@csie.org>
Subject: Re: [PATCH] drm/sun4i: fix build failure with CONFIG_DRM_SUN8I_MIXER=m
Date: Wed, 12 Sep 2018 16:02:03 +0200 [thread overview]
Message-ID: <20180912140203.vfhztb2bit7ueobc@flea> (raw)
In-Reply-To: <20180911201702.GN19774@phenom.ffwll.local>
[-- Attachment #1.1: Type: text/plain, Size: 1254 bytes --]
On Tue, Sep 11, 2018 at 10:17:02PM +0200, Daniel Vetter wrote:
> On Tue, Sep 11, 2018 at 01:33:25PM +0200, Maxime Ripard wrote:
> > Having DRM_SUN4I built-in but DRM_SUN8I_MIXER as a loadable module results in
> > a link error, as we try to access a symbol from the sun8i_tcon_top.ko module:
> >
> > ERROR: "sun8i_tcon_top_de_config" [drivers/gpu/drm/sun4i/sun4i-tcon.ko] undefined!
> > ERROR: "sun8i_tcon_top_set_hdmi_src" [drivers/gpu/drm/sun4i/sun4i-tcon.ko] undefined!
> > ERROR: "sun8i_tcon_top_of_table" [drivers/gpu/drm/sun4i/sun4i-tcon.ko] undefined!
> >
> > This solves the problem by adding a silent symbol for the tcon_top module,
> > building it as a separate module in exactly the cases that we need it,
> > but in a way that it is reachable by the other modules.
> >
> > Fixes: cf77d79b4e29 ("drm/sun4i: tcon: Add another way for matching mixers with tcon")
> > Fixes: 0305189afb32 ("drm/sun4i: tcon: Add support for R40 TCON")
> > Tested-by: Jon Hunter <jonathanh@nvidia.com>
> > Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
>
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
It's pushed, thanks!
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-09-12 14:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-11 11:33 [PATCH] drm/sun4i: fix build failure with CONFIG_DRM_SUN8I_MIXER=m Maxime Ripard
2018-09-11 20:17 ` Daniel Vetter
2018-09-12 9:53 ` Maxime Ripard
2018-09-12 14:25 ` Daniel Vetter
2018-09-12 15:47 ` Maxime Ripard
2018-09-12 15:53 ` Daniel Vetter
2018-09-13 8:02 ` Maxime Ripard
2018-09-13 8:19 ` Arnd Bergmann
2018-09-12 14:02 ` Maxime Ripard [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-07-06 12:45 Arnd Bergmann
2018-07-09 8:07 ` Maxime Ripard
2018-07-09 8:58 ` Jernej Škrabec
2018-07-09 8:58 ` Chen-Yu Tsai
2018-07-09 9:15 ` Maxime Ripard
2018-07-09 9:17 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180912140203.vfhztb2bit7ueobc@flea \
--to=maxime.ripard@bootlin.com \
--cc=arnd@arndb.de \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@siol.net \
--cc=jonathanh@nvidia.com \
--cc=naresh.kamboju@linaro.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox