From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: devel@driverdev.osuosl.org,
Michael Thayer <michael.thayer@oracle.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 01/15] staging: vboxvideo: Cleanup vbox_set_up_input_mapping()
Date: Fri, 28 Sep 2018 14:38:35 +0200 [thread overview]
Message-ID: <20180928123835.GA13609@kroah.com> (raw)
In-Reply-To: <20180926194206.23517-2-hdegoede@redhat.com>
On Wed, Sep 26, 2018 at 09:41:52PM +0200, Hans de Goede wrote:
> This cleanups 2 things:
>
> 1) The first time we loop over the crtc-s, to compare framebuffers, fb1 may
> get set to NULL by the fb1 = CRTC_FB(crtci); statement and then we call
> to_vbox_framebuffer() on it. The result of this call is only used for
> an address comparison, so we don't end up dereferencing the bad pointer,
> but still it is better to not do this.
>
> 2) Since we already figure out the first crtc with a fb in the first loop
> and store that in fb1, there is no need to loop over the crtc-s again just
> to find the first crtc with a fb again.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
I have two patch 1/15 in this series, making it 16 patches?
Something went odd on your end, can you please resend these properly?
thanks,
greg k-h
next prev parent reply other threads:[~2018-09-28 12:38 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 19:41 [PATCH 01/15] staging: vboxvideo: Convert to atomic modesetting API Hans de Goede
2018-09-26 19:41 ` [PATCH 01/15] staging: vboxvideo: Cleanup vbox_set_up_input_mapping() Hans de Goede
2018-09-28 12:38 ` Greg Kroah-Hartman [this message]
2018-09-29 12:23 ` Hans de Goede
2018-09-29 12:33 ` Greg Kroah-Hartman
2018-09-26 19:41 ` [PATCH 02/15] staging: vboxvideo: Remove empty encoder_helper_funcs Hans de Goede
2018-09-26 19:41 ` [PATCH 03/15] staging: vboxvideo: Temporarily remove page_flip support Hans de Goede
2018-09-26 19:41 ` [PATCH 04/15] staging: vboxvideo: Cache mode width, height and crtc panning in vbox_crtc Hans de Goede
2018-09-26 19:41 ` [PATCH 05/15] staging: vboxvideo: Atomic phase 1: convert cursor to universal plane Hans de Goede
2018-09-26 19:41 ` [PATCH 06/15] staging: vboxvideo: Atomic phase 1: Use drm_plane_helpers for primary plane Hans de Goede
2018-09-26 19:41 ` [PATCH 07/15] staging: vboxvideo: Atomic phase 2: Wire up state object handlers Hans de Goede
2018-09-26 19:41 ` [PATCH 08/15] staging: vboxvideo: Atomic phase 2: Stop using plane->fb and crtc->* Hans de Goede
2018-09-26 19:42 ` [PATCH 09/15] staging: vboxvideo: Atomic phase 3: Switch last bits over to atomic Hans de Goede
2018-09-26 19:42 ` [PATCH 10/15] staging: vboxvideo: Restore page-flip support Hans de Goede
2018-09-26 19:42 ` [PATCH 11/15] staging: vboxvideo: Fix DPMS support after atomic conversion Hans de Goede
2018-10-01 7:53 ` Daniel Vetter
2018-10-01 9:37 ` Hans de Goede
2018-10-01 16:52 ` Daniel Vetter
2018-10-01 21:14 ` Hans de Goede
2018-10-01 22:01 ` Daniel Vetter
2018-10-02 9:25 ` Hans de Goede
2018-10-02 9:50 ` Daniel Vetter
2018-09-26 19:42 ` [PATCH 12/15] staging: vboxvideo: Replace crtc_helper enable/disable functions Hans de Goede
2018-09-26 19:42 ` [PATCH 13/15] staging: vboxvideo: Call drm_atomic_helper_check_plane_state from atomic_check Hans de Goede
2018-09-26 19:42 ` [PATCH 14/15] staging: vboxvideo: Drop unnecessary drm_connector_helper_funcs callbacks Hans de Goede
2018-09-26 19:42 ` [PATCH 15/15] staging: vboxvideo: Use more drm_fb_helper functions Hans de Goede
2018-10-01 7:51 ` [PATCH 01/15] staging: vboxvideo: Convert to atomic modesetting API Daniel Vetter
2018-10-01 9:17 ` Hans de Goede
2018-10-01 16:53 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180928123835.GA13609@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=michael.thayer@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox