From: Daniel Vetter <daniel@ffwll.ch>
To: Hans de Goede <hdegoede@redhat.com>
Cc: devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Michael Thayer <michael.thayer@oracle.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 01/15] staging: vboxvideo: Convert to atomic modesetting API
Date: Mon, 1 Oct 2018 18:53:12 +0200 [thread overview]
Message-ID: <20181001165312.GF11082@phenom.ffwll.local> (raw)
In-Reply-To: <ad36afc6-c108-5b63-ba20-70d7288f83ba@redhat.com>
On Mon, Oct 01, 2018 at 11:17:57AM +0200, Hans de Goede wrote:
> Hi,
>
> On 01-10-18 09:51, Daniel Vetter wrote:
> > On Wed, Sep 26, 2018 at 09:41:51PM +0200, Hans de Goede wrote:
> > > Hi All,
> > >
> > > This series converts the vboxvideo driver to the modesetting API, once this
> > > is merged I will submit a patch to move the driver out of staging and into
> > > drivers/gpu/drm.
> > >
> > > This series consists of 3 parts:
> > >
> > > 1) More cleanups / prep work for atomic conversion
> > > 2) The actual atomic conversion, this is modelled after the atomic conversion
> > > of the qxl driver done by Gabriel Krisman Bertazi. Gabriel if you are
> > > reading this, thank you for providing a roadmap how to go about this.
> > > 3) Restore some features which were lost by the atomic conversion +
> > > more cleanups
> >
> > Given how tiny vbox is it's easier if I just review the overall diff I
> > think. Overall = patch that adds the entire driver to drm, ignoring what's
> > been going on in staging. Please reply with that (I can do it locally, but
> > that doesn't allow me to conveniently reply&comment).
>
> Yes I was planning on submitting a patch to move this out of staging and I
> was expecting you (or other drm people) to review that.
>
> I was waiting for things to be merged in staging first :)
>
> I need to do one more bugfix for an issue kbuild caught and then I will
> send the patch to move things.
Ok, sounds like a plan. I'll ignore this series here (except for the dpms
thing, which jumped out from all the churn to me).
Cheers, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2018-10-01 16:53 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 19:41 [PATCH 01/15] staging: vboxvideo: Convert to atomic modesetting API Hans de Goede
2018-09-26 19:41 ` [PATCH 01/15] staging: vboxvideo: Cleanup vbox_set_up_input_mapping() Hans de Goede
2018-09-28 12:38 ` Greg Kroah-Hartman
2018-09-29 12:23 ` Hans de Goede
2018-09-29 12:33 ` Greg Kroah-Hartman
2018-09-26 19:41 ` [PATCH 02/15] staging: vboxvideo: Remove empty encoder_helper_funcs Hans de Goede
2018-09-26 19:41 ` [PATCH 03/15] staging: vboxvideo: Temporarily remove page_flip support Hans de Goede
2018-09-26 19:41 ` [PATCH 04/15] staging: vboxvideo: Cache mode width, height and crtc panning in vbox_crtc Hans de Goede
2018-09-26 19:41 ` [PATCH 05/15] staging: vboxvideo: Atomic phase 1: convert cursor to universal plane Hans de Goede
2018-09-26 19:41 ` [PATCH 06/15] staging: vboxvideo: Atomic phase 1: Use drm_plane_helpers for primary plane Hans de Goede
2018-09-26 19:41 ` [PATCH 07/15] staging: vboxvideo: Atomic phase 2: Wire up state object handlers Hans de Goede
2018-09-26 19:41 ` [PATCH 08/15] staging: vboxvideo: Atomic phase 2: Stop using plane->fb and crtc->* Hans de Goede
2018-09-26 19:42 ` [PATCH 09/15] staging: vboxvideo: Atomic phase 3: Switch last bits over to atomic Hans de Goede
2018-09-26 19:42 ` [PATCH 10/15] staging: vboxvideo: Restore page-flip support Hans de Goede
2018-09-26 19:42 ` [PATCH 11/15] staging: vboxvideo: Fix DPMS support after atomic conversion Hans de Goede
2018-10-01 7:53 ` Daniel Vetter
2018-10-01 9:37 ` Hans de Goede
2018-10-01 16:52 ` Daniel Vetter
2018-10-01 21:14 ` Hans de Goede
2018-10-01 22:01 ` Daniel Vetter
2018-10-02 9:25 ` Hans de Goede
2018-10-02 9:50 ` Daniel Vetter
2018-09-26 19:42 ` [PATCH 12/15] staging: vboxvideo: Replace crtc_helper enable/disable functions Hans de Goede
2018-09-26 19:42 ` [PATCH 13/15] staging: vboxvideo: Call drm_atomic_helper_check_plane_state from atomic_check Hans de Goede
2018-09-26 19:42 ` [PATCH 14/15] staging: vboxvideo: Drop unnecessary drm_connector_helper_funcs callbacks Hans de Goede
2018-09-26 19:42 ` [PATCH 15/15] staging: vboxvideo: Use more drm_fb_helper functions Hans de Goede
2018-10-01 7:51 ` [PATCH 01/15] staging: vboxvideo: Convert to atomic modesetting API Daniel Vetter
2018-10-01 9:17 ` Hans de Goede
2018-10-01 16:53 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181001165312.GF11082@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=michael.thayer@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox