[PATCH] drm/atomic: Add missing () to function ref in kerneldoc

[PATCH] drm/atomic: Add missing () to function ref in kerneldoc

[Daniel Vetter]

Pure drive-by while reading code&docs.

Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 include/drm/drm_atomic.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/drm/drm_atomic.h b/include/drm/drm_atomic.h
index c09ecaf43825..627210f3ff59 100644
--- a/include/drm/drm_atomic.h
+++ b/include/drm/drm_atomic.h
@@ -139,9 +139,9 @@ struct drm_crtc_commit {
 	/**
 	 * @abort_completion:
 	 *
-	 * A flag that's set after drm_atomic_helper_setup_commit takes a second
-	 * reference for the completion of $drm_crtc_state.event. It's used by
-	 * the free code to remove the second reference if commit fails.
+	 * A flag that's set after drm_atomic_helper_setup_commit() takes a
+	 * second reference for the completion of $drm_crtc_state.event. It's
+	 * used by the free code to remove the second reference if commit fails.
 	 */
 	bool abort_completion;
 };
-- 
2.19.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/atomic: Add missing () to function ref in kerneldoc

[Lyude Paul]

Reviewed-by: Lyude Paul <lyude@redhat.com>

On Fri, 2018-10-12 at 09:34 +0200, Daniel Vetter wrote:
> Pure drive-by while reading code&docs.
> 
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
>  include/drm/drm_atomic.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/include/drm/drm_atomic.h b/include/drm/drm_atomic.h
> index c09ecaf43825..627210f3ff59 100644
> --- a/include/drm/drm_atomic.h
> +++ b/include/drm/drm_atomic.h
> @@ -139,9 +139,9 @@ struct drm_crtc_commit {
>  	/**
>  	 * @abort_completion:
>  	 *
> -	 * A flag that's set after drm_atomic_helper_setup_commit takes a
> second
> -	 * reference for the completion of $drm_crtc_state.event. It's used by
> -	 * the free code to remove the second reference if commit fails.
> +	 * A flag that's set after drm_atomic_helper_setup_commit() takes a
> +	 * second reference for the completion of $drm_crtc_state.event. It's
> +	 * used by the free code to remove the second reference if commit
> fails.
>  	 */
>  	bool abort_completion;
>  };
-- 
Cheers,
	Lyude Paul

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/atomic: Add missing () to function ref in kerneldoc

[Daniel Vetter]

On Wed, Oct 24, 2018 at 11:47:31AM -0400, Lyude Paul wrote:
> Reviewed-by: Lyude Paul <lyude@redhat.com>

Thanks for your review, patch applied.
-Daniel

> 
> On Fri, 2018-10-12 at 09:34 +0200, Daniel Vetter wrote:
> > Pure drive-by while reading code&docs.
> > 
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > ---
> >  include/drm/drm_atomic.h | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/include/drm/drm_atomic.h b/include/drm/drm_atomic.h
> > index c09ecaf43825..627210f3ff59 100644
> > --- a/include/drm/drm_atomic.h
> > +++ b/include/drm/drm_atomic.h
> > @@ -139,9 +139,9 @@ struct drm_crtc_commit {
> >  	/**
> >  	 * @abort_completion:
> >  	 *
> > -	 * A flag that's set after drm_atomic_helper_setup_commit takes a
> > second
> > -	 * reference for the completion of $drm_crtc_state.event. It's used by
> > -	 * the free code to remove the second reference if commit fails.
> > +	 * A flag that's set after drm_atomic_helper_setup_commit() takes a
> > +	 * second reference for the completion of $drm_crtc_state.event. It's
> > +	 * used by the free code to remove the second reference if commit
> > fails.
> >  	 */
> >  	bool abort_completion;
> >  };
> -- 
> Cheers,
> 	Lyude Paul
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel