From: Daniel Vetter <daniel@ffwll.ch>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Maxime Ripard <maxime.ripard@bootlin.com>,
dri-devel@lists.freedesktop.org, David Airlie <airlied@linux.ie>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Sean Paul <sean@poorly.run>
Subject: Re: [PATCH v1 1/1] drm: fix drm_can_sleep() comment
Date: Mon, 21 Jan 2019 10:30:01 +0100 [thread overview]
Message-ID: <20190121093001.GO3271@phenom.ffwll.local> (raw)
In-Reply-To: <20190120171217.12508-1-sam@ravnborg.org>
On Sun, Jan 20, 2019 at 06:12:17PM +0100, Sam Ravnborg wrote:
> Reversed logic when writing the original comment, now fixed.
>
> Fixes: e9eafcb58921 ("drm: move drm_can_sleep() to drm_util.h")
> Reported-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <maxime.ripard@bootlin.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
Thanks, merged.
-Daniel
> ---
> include/drm/drm_util.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/drm/drm_util.h b/include/drm/drm_util.h
> index 8163d35f8327..07b8e9f04599 100644
> --- a/include/drm/drm_util.h
> +++ b/include/drm/drm_util.h
> @@ -71,7 +71,7 @@
> * FIXME: All users of drm_can_sleep should be removed (see todo.rst)
> *
> * Returns:
> - * True if kgdb is active or we are in an atomic context or irqs are disabled
> + * False if kgdb is active, we are in atomic context or irqs are disabled.
> */
> static inline bool drm_can_sleep(void)
> {
> --
> 2.12.0
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2019-01-21 9:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-20 17:12 [PATCH v1 1/1] drm: fix drm_can_sleep() comment Sam Ravnborg
2019-01-21 9:30 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190121093001.GO3271@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=maxime.ripard@bootlin.com \
--cc=sam@ravnborg.org \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox