* [PATCH v1 1/1] drm: fix drm_can_sleep() comment
@ 2019-01-20 17:12 Sam Ravnborg
2019-01-21 9:30 ` Daniel Vetter
0 siblings, 1 reply; 2+ messages in thread
From: Sam Ravnborg @ 2019-01-20 17:12 UTC (permalink / raw)
To: dri-devel
Cc: Maxime Ripard, Sam Ravnborg, David Airlie, Laurent Pinchart,
Sean Paul
Reversed logic when writing the original comment, now fixed.
Fixes: e9eafcb58921 ("drm: move drm_can_sleep() to drm_util.h")
Reported-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: Sean Paul <sean@poorly.run>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
---
include/drm/drm_util.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/drm/drm_util.h b/include/drm/drm_util.h
index 8163d35f8327..07b8e9f04599 100644
--- a/include/drm/drm_util.h
+++ b/include/drm/drm_util.h
@@ -71,7 +71,7 @@
* FIXME: All users of drm_can_sleep should be removed (see todo.rst)
*
* Returns:
- * True if kgdb is active or we are in an atomic context or irqs are disabled
+ * False if kgdb is active, we are in atomic context or irqs are disabled.
*/
static inline bool drm_can_sleep(void)
{
--
2.12.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1 1/1] drm: fix drm_can_sleep() comment
2019-01-20 17:12 [PATCH v1 1/1] drm: fix drm_can_sleep() comment Sam Ravnborg
@ 2019-01-21 9:30 ` Daniel Vetter
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Vetter @ 2019-01-21 9:30 UTC (permalink / raw)
To: Sam Ravnborg
Cc: Maxime Ripard, dri-devel, David Airlie, Laurent Pinchart,
Sean Paul
On Sun, Jan 20, 2019 at 06:12:17PM +0100, Sam Ravnborg wrote:
> Reversed logic when writing the original comment, now fixed.
>
> Fixes: e9eafcb58921 ("drm: move drm_can_sleep() to drm_util.h")
> Reported-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <maxime.ripard@bootlin.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
Thanks, merged.
-Daniel
> ---
> include/drm/drm_util.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/drm/drm_util.h b/include/drm/drm_util.h
> index 8163d35f8327..07b8e9f04599 100644
> --- a/include/drm/drm_util.h
> +++ b/include/drm/drm_util.h
> @@ -71,7 +71,7 @@
> * FIXME: All users of drm_can_sleep should be removed (see todo.rst)
> *
> * Returns:
> - * True if kgdb is active or we are in an atomic context or irqs are disabled
> + * False if kgdb is active, we are in atomic context or irqs are disabled.
> */
> static inline bool drm_can_sleep(void)
> {
> --
> 2.12.0
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-21 9:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-20 17:12 [PATCH v1 1/1] drm: fix drm_can_sleep() comment Sam Ravnborg
2019-01-21 9:30 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox