* [PATCH 2/3] drm: tweak header name [not found] <20190124142448.23243-1-mst@redhat.com> @ 2019-02-08 6:02 ` Michael S. Tsirkin 2019-02-08 8:56 ` Daniel Vetter 0 siblings, 1 reply; 3+ messages in thread From: Michael S. Tsirkin @ 2019-02-08 6:02 UTC (permalink / raw) To: linux-kernel Cc: linux-arch, Arnd Bergmann, Maxime Ripard, dri-devel, David Airlie, Sean Paul Use linux/mman.h to make sure we get all mmap flags we need. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- include/drm/drmP.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/include/drm/drmP.h b/include/drm/drmP.h index bdb0d5548f39..a3184416ddc5 100644 --- a/include/drm/drmP.h +++ b/include/drm/drmP.h @@ -57,8 +57,7 @@ #include <linux/workqueue.h> #include <linux/dma-fence.h> #include <linux/module.h> - -#include <asm/mman.h> +#include <linux/mman.h> #include <asm/pgalloc.h> #include <linux/uaccess.h> -- MST _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/3] drm: tweak header name 2019-02-08 6:02 ` [PATCH 2/3] drm: tweak header name Michael S. Tsirkin @ 2019-02-08 8:56 ` Daniel Vetter 2019-02-08 12:55 ` Michael S. Tsirkin 0 siblings, 1 reply; 3+ messages in thread From: Daniel Vetter @ 2019-02-08 8:56 UTC (permalink / raw) To: Michael S. Tsirkin Cc: linux-kernel, linux-arch, Arnd Bergmann, Maarten Lankhorst, Maxime Ripard, Sean Paul, David Airlie, Daniel Vetter, dri-devel On Fri, Feb 08, 2019 at 01:02:58AM -0500, Michael S. Tsirkin wrote: > Use linux/mman.h to make sure we get all mmap flags we need. > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> drmP.h is seriously deprecated (and a monster mess). If this fixes anything, I think would be better to include the right header in the right places, and leave drmP.h to die quietly ... What exactly does this fix? -Daniel > --- > include/drm/drmP.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/include/drm/drmP.h b/include/drm/drmP.h > index bdb0d5548f39..a3184416ddc5 100644 > --- a/include/drm/drmP.h > +++ b/include/drm/drmP.h > @@ -57,8 +57,7 @@ > #include <linux/workqueue.h> > #include <linux/dma-fence.h> > #include <linux/module.h> > - > -#include <asm/mman.h> > +#include <linux/mman.h> > #include <asm/pgalloc.h> > #include <linux/uaccess.h> > > -- > MST > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/3] drm: tweak header name 2019-02-08 8:56 ` Daniel Vetter @ 2019-02-08 12:55 ` Michael S. Tsirkin 0 siblings, 0 replies; 3+ messages in thread From: Michael S. Tsirkin @ 2019-02-08 12:55 UTC (permalink / raw) To: linux-kernel, linux-arch, Arnd Bergmann, Maarten Lankhorst, Maxime Ripard, Sean Paul, David Airlie, dri-devel On Fri, Feb 08, 2019 at 09:56:59AM +0100, Daniel Vetter wrote: > On Fri, Feb 08, 2019 at 01:02:58AM -0500, Michael S. Tsirkin wrote: > > Use linux/mman.h to make sure we get all mmap flags we need. > > > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > > drmP.h is seriously deprecated (and a monster mess). If this fixes > anything, I think would be better to include the right header in the right > places, and leave drmP.h to die quietly ... > > What exactly does this fix? > -Daniel I don't know. I am moving flags from asm/mman.h and if there are direct users which there should not be, some code might break. Even if it's a bad header people copy code around, so why leave wrong examples there? What's the harm in being proactive? > > --- > > include/drm/drmP.h | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/include/drm/drmP.h b/include/drm/drmP.h > > index bdb0d5548f39..a3184416ddc5 100644 > > --- a/include/drm/drmP.h > > +++ b/include/drm/drmP.h > > @@ -57,8 +57,7 @@ > > #include <linux/workqueue.h> > > #include <linux/dma-fence.h> > > #include <linux/module.h> > > - > > -#include <asm/mman.h> > > +#include <linux/mman.h> > > #include <asm/pgalloc.h> > > #include <linux/uaccess.h> > > > > -- > > MST > > > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-08 12:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190124142448.23243-1-mst@redhat.com>
2019-02-08 6:02 ` [PATCH 2/3] drm: tweak header name Michael S. Tsirkin
2019-02-08 8:56 ` Daniel Vetter
2019-02-08 12:55 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox