From: Daniel Vetter <daniel@ffwll.ch>
To: Ramalingam C <ramalingam.c@intel.com>
Cc: tiwai@suse.de, daniel.vetter@ffwll.ch,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/audio: declaration of struct device
Date: Mon, 18 Feb 2019 10:03:00 +0100 [thread overview]
Message-ID: <20190218090300.GS2665@phenom.ffwll.local> (raw)
In-Reply-To: <1550293499-5560-1-git-send-email-ramalingam.c@intel.com>
On Sat, Feb 16, 2019 at 10:34:59AM +0530, Ramalingam C wrote:
> Header has used the references to struct device without it definition
> or declaration. Hence resulting in compilation warning such as
>
> "'struct device' declared inside parameter list..."
>
> This changes adds a declaration to struct device in the header to avoid
> any such warnings.
>
> Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
> cc: Takashi Iwai <tiwai@suse.de>
> cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Ok, I'll pick this one up for the mei-hdcp topic branch too.
-Daniel
> ---
> include/drm/drm_audio_component.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/drm/drm_audio_component.h b/include/drm/drm_audio_component.h
> index d0c7444319f5..a45f93487039 100644
> --- a/include/drm/drm_audio_component.h
> +++ b/include/drm/drm_audio_component.h
> @@ -5,6 +5,7 @@
> #define _DRM_AUDIO_COMPONENT_H_
>
> struct drm_audio_component;
> +struct device;
>
> /**
> * struct drm_audio_component_ops - Ops implemented by DRM driver, called by hda driver
> --
> 2.7.4
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2019-02-18 9:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-16 5:04 [PATCH] drm/audio: declaration of struct device Ramalingam C via dri-devel
2019-02-18 9:03 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190218090300.GS2665@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ramalingam.c@intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox