* [PATCH] drm/audio: declaration of struct device
@ 2019-02-16 5:04 Ramalingam C via dri-devel
2019-02-18 9:03 ` Daniel Vetter
0 siblings, 1 reply; 2+ messages in thread
From: Ramalingam C via dri-devel @ 2019-02-16 5:04 UTC (permalink / raw)
To: tiwai, daniel.vetter, dri-devel, intel-gfx
Header has used the references to struct device without it definition
or declaration. Hence resulting in compilation warning such as
"'struct device' declared inside parameter list..."
This changes adds a declaration to struct device in the header to avoid
any such warnings.
Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
cc: Takashi Iwai <tiwai@suse.de>
cc: Daniel Vetter <daniel.vetter@ffwll.ch>
---
include/drm/drm_audio_component.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/drm/drm_audio_component.h b/include/drm/drm_audio_component.h
index d0c7444319f5..a45f93487039 100644
--- a/include/drm/drm_audio_component.h
+++ b/include/drm/drm_audio_component.h
@@ -5,6 +5,7 @@
#define _DRM_AUDIO_COMPONENT_H_
struct drm_audio_component;
+struct device;
/**
* struct drm_audio_component_ops - Ops implemented by DRM driver, called by hda driver
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/audio: declaration of struct device
2019-02-16 5:04 [PATCH] drm/audio: declaration of struct device Ramalingam C via dri-devel
@ 2019-02-18 9:03 ` Daniel Vetter
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Vetter @ 2019-02-18 9:03 UTC (permalink / raw)
To: Ramalingam C; +Cc: tiwai, daniel.vetter, intel-gfx, dri-devel
On Sat, Feb 16, 2019 at 10:34:59AM +0530, Ramalingam C wrote:
> Header has used the references to struct device without it definition
> or declaration. Hence resulting in compilation warning such as
>
> "'struct device' declared inside parameter list..."
>
> This changes adds a declaration to struct device in the header to avoid
> any such warnings.
>
> Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
> cc: Takashi Iwai <tiwai@suse.de>
> cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Ok, I'll pick this one up for the mei-hdcp topic branch too.
-Daniel
> ---
> include/drm/drm_audio_component.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/drm/drm_audio_component.h b/include/drm/drm_audio_component.h
> index d0c7444319f5..a45f93487039 100644
> --- a/include/drm/drm_audio_component.h
> +++ b/include/drm/drm_audio_component.h
> @@ -5,6 +5,7 @@
> #define _DRM_AUDIO_COMPONENT_H_
>
> struct drm_audio_component;
> +struct device;
>
> /**
> * struct drm_audio_component_ops - Ops implemented by DRM driver, called by hda driver
> --
> 2.7.4
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-18 9:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-16 5:04 [PATCH] drm/audio: declaration of struct device Ramalingam C via dri-devel
2019-02-18 9:03 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox