From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: "Jonathan Gray" <jsg@jsg.id.au>,
"Ville Syrjälä" <ville.syrjala@intel.com>
Cc: Jos?? Roberto de Souza <jose.souza@intel.com>,
mesa-dev@lists.freedesktop.org,
Kenneth Graunke <kenneth@whitecape.org>,
dri-devel@lists.freedesktop.org
Subject: Re: [Mesa-dev] [PATCH] intel: Add more PCI Device IDs for Coffee Lake and Ice Lake.
Date: Tue, 19 Feb 2019 09:36:14 -0800 [thread overview]
Message-ID: <20190219173614.GH23434@intel.com> (raw)
In-Reply-To: <20190218055434.GA65436@largo.jsg.id.au>
On Mon, Feb 18, 2019 at 04:54:34PM +1100, Jonathan Gray wrote:
> Compared to linux and libdrm Mesa is missing a VLV and ICL id.
>
> 0x0f30
> ff049b6ce21d2814451afd4a116d001712e0116b
> drm/i915: bind driver to ValleyView chipsets
>
> 0x8A70
> d55cb4fa2cf0105bfb16b60a2846737b91fdc173
> drm/i915/icl: Add the ICL PCI IDs
>
> The Intel Media SDK describes these as
>
> /* VLV */
> { 0x0f30, MFX_HW_VLV, MFX_GT1 }, /* VLV mobile */
hmmm... no idea about this one...
Ville?
maybe we should just remove from kernel since it was never
missed from Mesa?
>
> /* ICL LP */
> { 0x8A70, MFX_HW_ICL_LP, MFX_GT1 }
This is pure display so no Mesa needed for this ID.
>
> and libdrm's intel_chipset.h describes the VLV id as
>
> #define PCI_CHIP_VALLEYVIEW_PO 0x0f30 /* VLV PO board */
>
> It isn't clear what the ICL configuration should be from public
> information.
>
> diff --git a/include/pci_ids/i965_pci_ids.h b/include/pci_ids/i965_pci_ids.h
> index b91abd7a3f9..3568007b1ef 100644
> --- a/include/pci_ids/i965_pci_ids.h
> +++ b/include/pci_ids/i965_pci_ids.h
> @@ -86,6 +86,7 @@ CHIPSET(0x0D2B, hsw_gt3, "Intel(R) Haswell")
> CHIPSET(0x0D0E, hsw_gt1, "Intel(R) Haswell")
> CHIPSET(0x0D1E, hsw_gt2, "Intel(R) Haswell")
> CHIPSET(0x0D2E, hsw_gt3, "Intel(R) Haswell")
> +CHIPSET(0x0F30, byt, "Intel(R) Bay Trail")
> CHIPSET(0x0F31, byt, "Intel(R) Bay Trail")
> CHIPSET(0x0F32, byt, "Intel(R) Bay Trail")
> CHIPSET(0x0F33, byt, "Intel(R) Bay Trail")
> @@ -212,4 +213,5 @@ CHIPSET(0x8A5A, icl_6x8, "Intel(R) HD Graphics (Ice Lake 6x8 GT1.5)")
> CHIPSET(0x8A5B, icl_4x8, "Intel(R) HD Graphics (Ice Lake 4x8 GT1)")
> CHIPSET(0x8A5C, icl_6x8, "Intel(R) HD Graphics (Ice Lake 6x8 GT1.5)")
> CHIPSET(0x8A5D, icl_4x8, "Intel(R) HD Graphics (Ice Lake 4x8 GT1)")
> +CHIPSET(0x8A70, icl_4x8, "Intel(R) HD Graphics (Ice Lake 4x8 GT1)")
> CHIPSET(0x8A71, icl_1x8, "Intel(R) HD Graphics (Ice Lake 1x8 GT0.5)")
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-02-19 17:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-02 8:07 [PATCH] intel: Add more PCI Device IDs for Coffee Lake and Ice Lake Rodrigo Vivi
2019-02-04 15:08 ` Lionel Landwerlin
2019-02-18 5:54 ` Jonathan Gray
2019-02-19 17:36 ` Rodrigo Vivi [this message]
2019-02-19 18:08 ` [Mesa-dev] " Ville Syrjälä
2019-02-19 18:13 ` Kenneth Graunke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190219173614.GH23434@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jose.souza@intel.com \
--cc=jsg@jsg.id.au \
--cc=kenneth@whitecape.org \
--cc=mesa-dev@lists.freedesktop.org \
--cc=ville.syrjala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox