dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
Cc: daniel.vetter@ffwll.ch, intel-gfx@lists.freedesktop.org,
	martin.peres@intel.com, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v1 0/3] Send a hotplug when edid changes
Date: Thu, 27 Jun 2019 13:29:17 +0200	[thread overview]
Message-ID: <20190627112917.GK12905@phenom.ffwll.local> (raw)
In-Reply-To: <20190627070016.7047-1-stanislav.lisovskiy@intel.com>

On Thu, Jun 27, 2019 at 10:00:14AM +0300, Stanislav Lisovskiy wrote:
> This series introduce to drm a way to determine if something else
> except connection_status had changed during probing, which
> can be used by other drivers as well. Another i915 specific part
> uses this approach to determine if edid had changed without
> changing the connection status and send a hotplug event.
> 
> Stanislav Lisovskiy (3):
>   drm: Add helper to compare edids.
>   drm: Introduce change counter to drm_connector
>   drm/i915: Send hotplug event if edid had changed.

There was a huge discussion a while back on what this all should look
like, with Pekka and Paul and others. This here seems to fall quite a bit
short on that.

https://lists.freedesktop.org/archives/dri-devel/2019-May/217588.html

Also please cc all the people involved in that previous discussion.

Wrt the patches: Documentation seems to be awol at least, that definitely
needs to be fixed. Maybe fix that, resend, and then use that to move the
overall discussion forward with everyone?
-Daniel

> 
>  drivers/gpu/drm/drm_connector.c              |  1 +
>  drivers/gpu/drm/drm_edid.c                   | 26 ++++++++++++++++++
>  drivers/gpu/drm/drm_probe_helper.c           | 29 ++++++++++++++++++--
>  drivers/gpu/drm/i915/display/intel_dp.c      | 16 ++++++++++-
>  drivers/gpu/drm/i915/display/intel_hdmi.c    | 16 +++++++++--
>  drivers/gpu/drm/i915/display/intel_hotplug.c | 20 ++++++++++----
>  include/drm/drm_connector.h                  |  2 ++
>  include/drm/drm_edid.h                       |  2 ++
>  8 files changed, 101 insertions(+), 11 deletions(-)
> 
> -- 
> 2.17.1
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-06-27 11:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-27  7:00 [PATCH v1 0/3] Send a hotplug when edid changes Stanislav Lisovskiy
2019-06-27  7:00 ` [PATCH v1 1/3] drm: Add helper to compare edids Stanislav Lisovskiy
2019-06-27  7:00 ` [PATCH v1 2/3] drm: Introduce change counter to drm_connector Stanislav Lisovskiy
2019-06-27 11:29 ` Daniel Vetter [this message]
2019-06-27 11:45   ` [PATCH v1 0/3] Send a hotplug when edid changes Lisovskiy, Stanislav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190627112917.GK12905@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=martin.peres@intel.com \
    --cc=stanislav.lisovskiy@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox