Re: [PATCH v1 0/3] Send a hotplug when edid changes

["Lisovskiy, Stanislav" <stanislav.lisovskiy@intel.com>]

On Thu, 2019-06-27 at 13:29 +0200, Daniel Vetter wrote:
> On Thu, Jun 27, 2019 at 10:00:14AM +0300, Stanislav Lisovskiy wrote:
> > This series introduce to drm a way to determine if something else
> > except connection_status had changed during probing, which
> > can be used by other drivers as well. Another i915 specific part
> > uses this approach to determine if edid had changed without
> > changing the connection status and send a hotplug event.
> > 
> > Stanislav Lisovskiy (3):
> >   drm: Add helper to compare edids.
> >   drm: Introduce change counter to drm_connector
> >   drm/i915: Send hotplug event if edid had changed.
> 
> There was a huge discussion a while back on what this all should look
> like, with Pekka and Paul and others. This here seems to fall quite a
> bit
> short on that.
> 
> https://lists.freedesktop.org/archives/dri-devel/2019-May/217588.html
> 
> Also please cc all the people involved in that previous discussion.
> 
> Wrt the patches: Documentation seems to be awol at least, that
> definitely
> needs to be fixed. Maybe fix that, resend, and then use that to move
> the
> overall discussion forward with everyone?
> -Daniel

Yes, I read some part of it. Also used your idea about the counter as a
way to propagate connector updates, such as edid change and etc, from
here:

https://lists.freedesktop.org/archives/dri-devel/2019-April/214572.html

As currently we analyze only connection status and nothing else.
Gwang-Gyeong is now doing some other task, so his patches were
transfered to me - however some changes had to be done to make it
work(used kms_chamelium edid_change tests to check).

I will include all people into discussion and documentation seems to be
a good idea as well.

> 
> > 
> >  drivers/gpu/drm/drm_connector.c              |  1 +
> >  drivers/gpu/drm/drm_edid.c                   | 26
> > ++++++++++++++++++
> >  drivers/gpu/drm/drm_probe_helper.c           | 29
> > ++++++++++++++++++--
> >  drivers/gpu/drm/i915/display/intel_dp.c      | 16 ++++++++++-
> >  drivers/gpu/drm/i915/display/intel_hdmi.c    | 16 +++++++++--
> >  drivers/gpu/drm/i915/display/intel_hotplug.c | 20 ++++++++++----
> >  include/drm/drm_connector.h                  |  2 ++
> >  include/drm/drm_edid.h                       |  2 ++
> >  8 files changed, 101 insertions(+), 11 deletions(-)
> > 
> > -- 
> > 2.17.1
> > 
> 
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx