Re: mmotm 2019-07-04-15-01 uploaded (gpu/drm/i915/oa/)

Re: mmotm 2019-07-04-15-01 uploaded (gpu/drm/i915/oa/)

[Randy Dunlap]

On 7/4/19 3:01 PM, akpm@linux-foundation.org wrote:
> The mm-of-the-moment snapshot 2019-07-04-15-01 has been uploaded to
> 
>    http://www.ozlabs.org/~akpm/mmotm/
> 
> mmotm-readme.txt says
> 
> README for mm-of-the-moment:
> 
> http://www.ozlabs.org/~akpm/mmotm/

I get a lot of these but don't see/know what causes them:

../scripts/Makefile.build:42: ../drivers/gpu/drm/i915/oa/Makefile: No such file or directory
make[6]: *** No rule to make target '../drivers/gpu/drm/i915/oa/Makefile'.  Stop.
../scripts/Makefile.build:498: recipe for target 'drivers/gpu/drm/i915/oa' failed
make[5]: *** [drivers/gpu/drm/i915/oa] Error 2
../scripts/Makefile.build:498: recipe for target 'drivers/gpu/drm/i915' failed

-- 
~Randy

Re: mmotm 2019-07-04-15-01 uploaded (gpu/drm/i915/oa/)

[Randy Dunlap]

On 7/4/19 6:09 PM, Randy Dunlap wrote:
> On 7/4/19 3:01 PM, akpm@linux-foundation.org wrote:
>> The mm-of-the-moment snapshot 2019-07-04-15-01 has been uploaded to
>>
>>    http://www.ozlabs.org/~akpm/mmotm/
>>
>> mmotm-readme.txt says
>>
>> README for mm-of-the-moment:
>>
>> http://www.ozlabs.org/~akpm/mmotm/
> 
> I get a lot of these but don't see/know what causes them:
> 
> ../scripts/Makefile.build:42: ../drivers/gpu/drm/i915/oa/Makefile: No such file or directory
> make[6]: *** No rule to make target '../drivers/gpu/drm/i915/oa/Makefile'.  Stop.
> ../scripts/Makefile.build:498: recipe for target 'drivers/gpu/drm/i915/oa' failed
> make[5]: *** [drivers/gpu/drm/i915/oa] Error 2
> ../scripts/Makefile.build:498: recipe for target 'drivers/gpu/drm/i915' failed
> 

[+ linux-kbuild]

It seems to have something to do with "modules.order".

But!!!
# CONFIG_DRM_I915 it not set

-- 
~Randy

Re: mmotm 2019-07-04-15-01 uploaded (gpu/drm/i915/oa/)

[Masahiro Yamada]

On Fri, Jul 5, 2019 at 10:09 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> On 7/4/19 3:01 PM, akpm@linux-foundation.org wrote:
> > The mm-of-the-moment snapshot 2019-07-04-15-01 has been uploaded to
> >
> >    http://www.ozlabs.org/~akpm/mmotm/
> >
> > mmotm-readme.txt says
> >
> > README for mm-of-the-moment:
> >
> > http://www.ozlabs.org/~akpm/mmotm/
>
> I get a lot of these but don't see/know what causes them:
>
> ../scripts/Makefile.build:42: ../drivers/gpu/drm/i915/oa/Makefile: No such file or directory
> make[6]: *** No rule to make target '../drivers/gpu/drm/i915/oa/Makefile'.  Stop.
> ../scripts/Makefile.build:498: recipe for target 'drivers/gpu/drm/i915/oa' failed
> make[5]: *** [drivers/gpu/drm/i915/oa] Error 2
> ../scripts/Makefile.build:498: recipe for target 'drivers/gpu/drm/i915' failed
>

I checked next-20190704 tag.

I see the empty file
drivers/gpu/drm/i915/oa/Makefile

Did someone delete it?


-- 
Best Regards
Masahiro Yamada

Re: mmotm 2019-07-04-15-01 uploaded (gpu/drm/i915/oa/)

[Masahiro Yamada]

On Fri, Jul 5, 2019 at 12:05 PM Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
>
> On Fri, Jul 5, 2019 at 10:09 AM Randy Dunlap <rdunlap@infradead.org> wrote:
> >
> > On 7/4/19 3:01 PM, akpm@linux-foundation.org wrote:
> > > The mm-of-the-moment snapshot 2019-07-04-15-01 has been uploaded to
> > >
> > >    http://www.ozlabs.org/~akpm/mmotm/
> > >
> > > mmotm-readme.txt says
> > >
> > > README for mm-of-the-moment:
> > >
> > > http://www.ozlabs.org/~akpm/mmotm/
> >
> > I get a lot of these but don't see/know what causes them:
> >
> > ../scripts/Makefile.build:42: ../drivers/gpu/drm/i915/oa/Makefile: No such file or directory
> > make[6]: *** No rule to make target '../drivers/gpu/drm/i915/oa/Makefile'.  Stop.
> > ../scripts/Makefile.build:498: recipe for target 'drivers/gpu/drm/i915/oa' failed
> > make[5]: *** [drivers/gpu/drm/i915/oa] Error 2
> > ../scripts/Makefile.build:498: recipe for target 'drivers/gpu/drm/i915' failed
> >
>
> I checked next-20190704 tag.
>
> I see the empty file
> drivers/gpu/drm/i915/oa/Makefile
>
> Did someone delete it?
>


I think "obj-y += oa/"
in drivers/gpu/drm/i915/Makefile
is redundant.



-- 
Best Regards
Masahiro Yamada

Re: mmotm 2019-07-04-15-01 uploaded (gpu/drm/i915/oa/)

[Randy Dunlap]

On 7/4/19 8:09 PM, Masahiro Yamada wrote:
> On Fri, Jul 5, 2019 at 12:05 PM Masahiro Yamada
> <yamada.masahiro@socionext.com> wrote:
>>
>> On Fri, Jul 5, 2019 at 10:09 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>>>
>>> On 7/4/19 3:01 PM, akpm@linux-foundation.org wrote:
>>>> The mm-of-the-moment snapshot 2019-07-04-15-01 has been uploaded to
>>>>
>>>>    http://www.ozlabs.org/~akpm/mmotm/
>>>>
>>>> mmotm-readme.txt says
>>>>
>>>> README for mm-of-the-moment:
>>>>
>>>> http://www.ozlabs.org/~akpm/mmotm/
>>>
>>> I get a lot of these but don't see/know what causes them:
>>>
>>> ../scripts/Makefile.build:42: ../drivers/gpu/drm/i915/oa/Makefile: No such file or directory
>>> make[6]: *** No rule to make target '../drivers/gpu/drm/i915/oa/Makefile'.  Stop.
>>> ../scripts/Makefile.build:498: recipe for target 'drivers/gpu/drm/i915/oa' failed
>>> make[5]: *** [drivers/gpu/drm/i915/oa] Error 2
>>> ../scripts/Makefile.build:498: recipe for target 'drivers/gpu/drm/i915' failed
>>>
>>
>> I checked next-20190704 tag.
>>
>> I see the empty file
>> drivers/gpu/drm/i915/oa/Makefile
>>
>> Did someone delete it?
>>
> 
> 
> I think "obj-y += oa/"
> in drivers/gpu/drm/i915/Makefile
> is redundant.

Thanks.  It seems to be working after deleting that line.

-- 
~Randy

Re: mmotm 2019-07-04-15-01 uploaded (gpu/drm/i915/oa/)

[Masahiro Yamada]

On Fri, Jul 5, 2019 at 12:23 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> On 7/4/19 8:09 PM, Masahiro Yamada wrote:
> > On Fri, Jul 5, 2019 at 12:05 PM Masahiro Yamada
> > <yamada.masahiro@socionext.com> wrote:
> >>
> >> On Fri, Jul 5, 2019 at 10:09 AM Randy Dunlap <rdunlap@infradead.org> wrote:
> >>>
> >>> On 7/4/19 3:01 PM, akpm@linux-foundation.org wrote:
> >>>> The mm-of-the-moment snapshot 2019-07-04-15-01 has been uploaded to
> >>>>
> >>>>    http://www.ozlabs.org/~akpm/mmotm/
> >>>>
> >>>> mmotm-readme.txt says
> >>>>
> >>>> README for mm-of-the-moment:
> >>>>
> >>>> http://www.ozlabs.org/~akpm/mmotm/
> >>>
> >>> I get a lot of these but don't see/know what causes them:
> >>>
> >>> ../scripts/Makefile.build:42: ../drivers/gpu/drm/i915/oa/Makefile: No such file or directory
> >>> make[6]: *** No rule to make target '../drivers/gpu/drm/i915/oa/Makefile'.  Stop.
> >>> ../scripts/Makefile.build:498: recipe for target 'drivers/gpu/drm/i915/oa' failed
> >>> make[5]: *** [drivers/gpu/drm/i915/oa] Error 2
> >>> ../scripts/Makefile.build:498: recipe for target 'drivers/gpu/drm/i915' failed
> >>>
> >>
> >> I checked next-20190704 tag.
> >>
> >> I see the empty file
> >> drivers/gpu/drm/i915/oa/Makefile
> >>
> >> Did someone delete it?
> >>
> >
> >
> > I think "obj-y += oa/"
> > in drivers/gpu/drm/i915/Makefile
> > is redundant.
>
> Thanks.  It seems to be working after deleting that line.


Could you check whether or not
drivers/gpu/drm/i915/oa/Makefile exists in your source tree?

Your build log says it was missing.

But, commit 5ed7a0cf3394 ("drm/i915: Move OA files to separate folder")
added it.  (It is just an empty file)

I am just wondering why.


-- 
Best Regards
Masahiro Yamada

Re: mmotm 2019-07-04-15-01 uploaded (gpu/drm/i915/oa/)

[Randy Dunlap]

On 7/4/19 8:44 PM, Masahiro Yamada wrote:
> On Fri, Jul 5, 2019 at 12:23 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>>
>> On 7/4/19 8:09 PM, Masahiro Yamada wrote:
>>> On Fri, Jul 5, 2019 at 12:05 PM Masahiro Yamada
>>> <yamada.masahiro@socionext.com> wrote:
>>>>
>>>> On Fri, Jul 5, 2019 at 10:09 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>>>>>
>>>>> On 7/4/19 3:01 PM, akpm@linux-foundation.org wrote:
>>>>>> The mm-of-the-moment snapshot 2019-07-04-15-01 has been uploaded to
>>>>>>
>>>>>>    http://www.ozlabs.org/~akpm/mmotm/
>>>>>>
>>>>>> mmotm-readme.txt says
>>>>>>
>>>>>> README for mm-of-the-moment:
>>>>>>
>>>>>> http://www.ozlabs.org/~akpm/mmotm/
>>>>>
>>>>> I get a lot of these but don't see/know what causes them:
>>>>>
>>>>> ../scripts/Makefile.build:42: ../drivers/gpu/drm/i915/oa/Makefile: No such file or directory
>>>>> make[6]: *** No rule to make target '../drivers/gpu/drm/i915/oa/Makefile'.  Stop.
>>>>> ../scripts/Makefile.build:498: recipe for target 'drivers/gpu/drm/i915/oa' failed
>>>>> make[5]: *** [drivers/gpu/drm/i915/oa] Error 2
>>>>> ../scripts/Makefile.build:498: recipe for target 'drivers/gpu/drm/i915' failed
>>>>>
>>>>
>>>> I checked next-20190704 tag.
>>>>
>>>> I see the empty file
>>>> drivers/gpu/drm/i915/oa/Makefile
>>>>
>>>> Did someone delete it?
>>>>
>>>
>>>
>>> I think "obj-y += oa/"
>>> in drivers/gpu/drm/i915/Makefile
>>> is redundant.
>>
>> Thanks.  It seems to be working after deleting that line.
> 
> 
> Could you check whether or not
> drivers/gpu/drm/i915/oa/Makefile exists in your source tree?

It does not.

> Your build log says it was missing.
> 
> But, commit 5ed7a0cf3394 ("drm/i915: Move OA files to separate folder")
> added it.  (It is just an empty file)
> 
> I am just wondering why.

I am not using any git tree(s) for this.  Just patches.

That Makefile is in patch-v5.2-rc7-next-20190704.xz.

I don't know how Andrew generates the linux-next.patch file for mmotm,
but I don't see that Makefile anywhere in mmotm, although the rest of
the i915/oa/ files seems to be there.

Maybe diff skips empty files unless told to save them?

-- 
~Randy

Re: mmotm 2019-07-04-15-01 uploaded (gpu/drm/i915/oa/)

[Jani Nikula]

On Fri, 05 Jul 2019, Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
> On Fri, Jul 5, 2019 at 12:23 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>>
>> On 7/4/19 8:09 PM, Masahiro Yamada wrote:
>> > On Fri, Jul 5, 2019 at 12:05 PM Masahiro Yamada
>> > <yamada.masahiro@socionext.com> wrote:
>> >>
>> >> On Fri, Jul 5, 2019 at 10:09 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>> >>>
>> >>> On 7/4/19 3:01 PM, akpm@linux-foundation.org wrote:
>> >>>> The mm-of-the-moment snapshot 2019-07-04-15-01 has been uploaded to
>> >>>>
>> >>>>    http://www.ozlabs.org/~akpm/mmotm/
>> >>>>
>> >>>> mmotm-readme.txt says
>> >>>>
>> >>>> README for mm-of-the-moment:
>> >>>>
>> >>>> http://www.ozlabs.org/~akpm/mmotm/
>> >>>
>> >>> I get a lot of these but don't see/know what causes them:
>> >>>
>> >>> ../scripts/Makefile.build:42: ../drivers/gpu/drm/i915/oa/Makefile: No such file or directory
>> >>> make[6]: *** No rule to make target '../drivers/gpu/drm/i915/oa/Makefile'.  Stop.
>> >>> ../scripts/Makefile.build:498: recipe for target 'drivers/gpu/drm/i915/oa' failed
>> >>> make[5]: *** [drivers/gpu/drm/i915/oa] Error 2
>> >>> ../scripts/Makefile.build:498: recipe for target 'drivers/gpu/drm/i915' failed
>> >>>
>> >>
>> >> I checked next-20190704 tag.
>> >>
>> >> I see the empty file
>> >> drivers/gpu/drm/i915/oa/Makefile
>> >>
>> >> Did someone delete it?
>> >>
>> >
>> >
>> > I think "obj-y += oa/"
>> > in drivers/gpu/drm/i915/Makefile
>> > is redundant.
>>
>> Thanks.  It seems to be working after deleting that line.
>
>
> Could you check whether or not
> drivers/gpu/drm/i915/oa/Makefile exists in your source tree?
>
> Your build log says it was missing.
>
> But, commit 5ed7a0cf3394 ("drm/i915: Move OA files to separate folder")
> added it.  (It is just an empty file)
>
> I am just wondering why.

I've sent patches adding some content, and they'll make their way
upstream eventually. I am not sure why the empty file was added
originally. Perhaps as a placeholder, seemed benign enough.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: mmotm 2019-07-04-15-01 uploaded (gpu/drm/i915/oa/)

[Stephen Rothwell]

[-- Attachment #1.1: Type: text/plain, Size: 985 bytes --]

Hi Masahiro,

On Fri, 5 Jul 2019 12:05:49 +0900 Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
>
> On Fri, Jul 5, 2019 at 10:09 AM Randy Dunlap <rdunlap@infradead.org> wrote:
> >
> > I get a lot of these but don't see/know what causes them:
> >
> > ../scripts/Makefile.build:42: ../drivers/gpu/drm/i915/oa/Makefile: No such file or directory
> > make[6]: *** No rule to make target '../drivers/gpu/drm/i915/oa/Makefile'.  Stop.
> > ../scripts/Makefile.build:498: recipe for target 'drivers/gpu/drm/i915/oa' failed
> > make[5]: *** [drivers/gpu/drm/i915/oa] Error 2
> > ../scripts/Makefile.build:498: recipe for target 'drivers/gpu/drm/i915' failed
> >  
> 
> I checked next-20190704 tag.
> 
> I see the empty file
> drivers/gpu/drm/i915/oa/Makefile
> 
> Did someone delete it?

Commit

  5ed7a0cf3394 ("drm/i915: Move OA files to separate folder")

from the drm-intel tree seems to have created it as an empty file.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: mmotm 2019-07-04-15-01 uploaded (gpu/drm/i915/oa/)

[Andrew Morton]

On Fri, 5 Jul 2019 13:14:35 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> > I checked next-20190704 tag.
> > 
> > I see the empty file
> > drivers/gpu/drm/i915/oa/Makefile
> > 
> > Did someone delete it?
> 
> Commit
> 
>   5ed7a0cf3394 ("drm/i915: Move OA files to separate folder")
> 
> from the drm-intel tree seems to have created it as an empty file.

hrm.

diff(1) doesn't seem to know how to handle a zero-length file.

y:/home/akpm> mkdir foo
y:/home/akpm> cd foo
y:/home/akpm/foo> touch x
y:/home/akpm/foo> diff -uN x y
y:/home/akpm/foo> date > x
y:/home/akpm/foo> diff -uN x y
--- x   2019-07-04 21:58:37.815028211 -0700
+++ y   1969-12-31 16:00:00.000000000 -0800
@@ -1 +0,0 @@
-Thu Jul  4 21:58:37 PDT 2019

So when comparing a zero-length file with a non-existent file, diff
produces no output.


This'll make things happy.  And I guess it should be done to protect
all the valuable intellectual property in that file.

--- /dev/null
+++ a/drivers/gpu/drm/i915/oa/Makefile
@@ -0,0 +1 @@
+# SPDX-License-Identifier: GPL-2.0
_

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: mmotm 2019-07-04-15-01 uploaded (gpu/drm/i915/oa/)

[Joe Perches]

On Thu, 2019-07-04 at 22:09 -0700, Andrew Morton wrote:
> diff(1) doesn't seem to know how to handle a zero-length file.
> 
> y:/home/akpm> mkdir foo
> y:/home/akpm> cd foo
> y:/home/akpm/foo> touch x
> y:/home/akpm/foo> diff -uN x y
> y:/home/akpm/foo> date > x
> y:/home/akpm/foo> diff -uN x y
> --- x   2019-07-04 21:58:37.815028211 -0700
> +++ y   1969-12-31 16:00:00.000000000 -0800
> @@ -1 +0,0 @@
> -Thu Jul  4 21:58:37 PDT 2019
> 
> So when comparing a zero-length file with a non-existent file, diff
> produces no output.

Why use the -N option ?

$ diff --help
[...]
  -N, --new-file                  treat absent files as empty

otherwise

$ cd $(mktemp -d -p .)
$ touch x
$ diff -u x y
diff: y: No such file or directory


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: mmotm 2019-07-04-15-01 uploaded (gpu/drm/i915/oa/)

[Andrew Morton]

On Thu, 04 Jul 2019 22:22:41 -0700 Joe Perches <joe@perches.com> wrote:

> > So when comparing a zero-length file with a non-existent file, diff
> > produces no output.
> 
> Why use the -N option ?
> 
> $ diff --help
> [...]
>   -N, --new-file                  treat absent files as empty
> 
> otherwise
> 
> $ cd $(mktemp -d -p .)
> $ touch x
> $ diff -u x y
> diff: y: No such file or directory

Without -N diff fails and exits with an error.  -N does what's desired
as long as the non-missing file isn't empty.