From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>,
DRI Development <dri-devel@lists.freedesktop.org>,
Emil Velikov <emil.velikov@collabora.com>
Subject: Re: [PATCH] drm/crc: Actually allow to change the crc source
Date: Thu, 22 Aug 2019 15:20:38 +0300 [thread overview]
Message-ID: <20190822122038.GK5942@intel.com> (raw)
In-Reply-To: <20190821203835.18314-1-daniel.vetter@ffwll.ch>
On Wed, Aug 21, 2019 at 10:38:35PM +0200, Daniel Vetter wrote:
> Oops.
>
> Fixes: 9edbf1fa600a ("drm: Add API for capturing frame CRCs")
> Cc: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> Cc: Emil Velikov <emil.velikov@collabora.com>
> Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
> drivers/gpu/drm/drm_debugfs_crc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_debugfs_crc.c b/drivers/gpu/drm/drm_debugfs_crc.c
> index be1b7ba92ffe..6fe693ee15f9 100644
> --- a/drivers/gpu/drm/drm_debugfs_crc.c
> +++ b/drivers/gpu/drm/drm_debugfs_crc.c
> @@ -369,7 +369,7 @@ void drm_debugfs_crtc_crc_add(struct drm_crtc *crtc)
>
> crc_ent = debugfs_create_dir("crc", crtc->debugfs_entry);
>
> - debugfs_create_file("control", S_IRUGO, crc_ent, crtc,
> + debugfs_create_file("control", S_IRUGO | S_IWUSR, crc_ent, crtc,
> &drm_crtc_crc_control_fops);
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
But could we please go octal? My brain can't decode that alphabet soup.
> debugfs_create_file("data", S_IRUGO, crc_ent, crtc,
> &drm_crtc_crc_data_fops);
> --
> 2.23.0.rc1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-08-22 12:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 20:38 [PATCH] drm/crc: Actually allow to change the crc source Daniel Vetter
2019-08-22 12:20 ` Ville Syrjälä [this message]
2020-01-28 15:49 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190822122038.GK5942@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.velikov@collabora.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox