[PATCH] drm/crc: Actually allow to change the crc source

[PATCH] drm/crc: Actually allow to change the crc source

[Daniel Vetter]

Oops.

Fixes: 9edbf1fa600a ("drm: Add API for capturing frame CRCs")
Cc: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Cc: Emil Velikov <emil.velikov@collabora.com>
Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 drivers/gpu/drm/drm_debugfs_crc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_debugfs_crc.c b/drivers/gpu/drm/drm_debugfs_crc.c
index be1b7ba92ffe..6fe693ee15f9 100644
--- a/drivers/gpu/drm/drm_debugfs_crc.c
+++ b/drivers/gpu/drm/drm_debugfs_crc.c
@@ -369,7 +369,7 @@ void drm_debugfs_crtc_crc_add(struct drm_crtc *crtc)
 
 	crc_ent = debugfs_create_dir("crc", crtc->debugfs_entry);
 
-	debugfs_create_file("control", S_IRUGO, crc_ent, crtc,
+	debugfs_create_file("control", S_IRUGO | S_IWUSR, crc_ent, crtc,
 			    &drm_crtc_crc_control_fops);
 	debugfs_create_file("data", S_IRUGO, crc_ent, crtc,
 			    &drm_crtc_crc_data_fops);
-- 
2.23.0.rc1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/crc: Actually allow to change the crc source

[Ville Syrjälä]

On Wed, Aug 21, 2019 at 10:38:35PM +0200, Daniel Vetter wrote:
> Oops.
> 
> Fixes: 9edbf1fa600a ("drm: Add API for capturing frame CRCs")
> Cc: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> Cc: Emil Velikov <emil.velikov@collabora.com>
> Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
>  drivers/gpu/drm/drm_debugfs_crc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_debugfs_crc.c b/drivers/gpu/drm/drm_debugfs_crc.c
> index be1b7ba92ffe..6fe693ee15f9 100644
> --- a/drivers/gpu/drm/drm_debugfs_crc.c
> +++ b/drivers/gpu/drm/drm_debugfs_crc.c
> @@ -369,7 +369,7 @@ void drm_debugfs_crtc_crc_add(struct drm_crtc *crtc)
>  
>  	crc_ent = debugfs_create_dir("crc", crtc->debugfs_entry);
>  
> -	debugfs_create_file("control", S_IRUGO, crc_ent, crtc,
> +	debugfs_create_file("control", S_IRUGO | S_IWUSR, crc_ent, crtc,
>  			    &drm_crtc_crc_control_fops);

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

But could we please go octal? My brain can't decode that alphabet soup.

>  	debugfs_create_file("data", S_IRUGO, crc_ent, crtc,
>  			    &drm_crtc_crc_data_fops);
> -- 
> 2.23.0.rc1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/crc: Actually allow to change the crc source

[Daniel Vetter]

On Thu, Aug 22, 2019 at 2:20 PM Ville Syrjälä
<ville.syrjala@linux.intel.com> wrote:
>
> On Wed, Aug 21, 2019 at 10:38:35PM +0200, Daniel Vetter wrote:
> > Oops.
> >
> > Fixes: 9edbf1fa600a ("drm: Add API for capturing frame CRCs")
> > Cc: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> > Cc: Emil Velikov <emil.velikov@collabora.com>
> > Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > ---
> >  drivers/gpu/drm/drm_debugfs_crc.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/drm_debugfs_crc.c b/drivers/gpu/drm/drm_debugfs_crc.c
> > index be1b7ba92ffe..6fe693ee15f9 100644
> > --- a/drivers/gpu/drm/drm_debugfs_crc.c
> > +++ b/drivers/gpu/drm/drm_debugfs_crc.c
> > @@ -369,7 +369,7 @@ void drm_debugfs_crtc_crc_add(struct drm_crtc *crtc)
> >
> >       crc_ent = debugfs_create_dir("crc", crtc->debugfs_entry);
> >
> > -     debugfs_create_file("control", S_IRUGO, crc_ent, crtc,
> > +     debugfs_create_file("control", S_IRUGO | S_IWUSR, crc_ent, crtc,
> >                           &drm_crtc_crc_control_fops);
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Found this old patch of mine, finally applied it. Thanks for your review.
-Daniel

>
> But could we please go octal? My brain can't decode that alphabet soup.
>
> >       debugfs_create_file("data", S_IRUGO, crc_ent, crtc,
> >                           &drm_crtc_crc_data_fops);
> > --
> > 2.23.0.rc1
> >
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
> --
> Ville Syrjälä
> Intel



-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel