From: Boris Brezillon <boris.brezillon@collabora.com>
To: "Jernej Škrabec" <jernej.skrabec@siol.net>
Cc: Nikita Yushchenko <nikita.yoush@cogentembedded.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Andrey Smirnov <andrew.smirnov@gmail.com>,
Jonas Karlman <jonas@kwiboo.se>,
Seung-Woo Kim <sw0312.kim@samsung.com>,
dri-devel@lists.freedesktop.org,
Kyungmin Park <kyungmin.park@samsung.com>,
Thierry Reding <thierry.reding@gmail.com>,
Chris Healy <Chris.Healy@zii.aero>,
kernel@collabora.com, Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH v2 18/21] drm/bridge: lvds-encoder: Implement basic bus format negotiation
Date: Mon, 26 Aug 2019 20:17:40 +0200 [thread overview]
Message-ID: <20190826201740.28d93350@collabora.com> (raw)
In-Reply-To: <2507680.nRZY6kW3Wv@jernej-laptop>
On Mon, 26 Aug 2019 18:15:41 +0200
Jernej Škrabec <jernej.skrabec@siol.net> wrote:
> Hi Boris!
>
> Dne ponedeljek, 26. avgust 2019 ob 17:26:46 CEST je Boris Brezillon
> napisal(a):
> > Some LVDS encoder might support several input/output bus formats. Add
> > a way to describe the one used on a specific design by adding optional
> > 'data-mapping' properties to the input/output ports.
> >
> > Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
> > ---
> > Changes in v2:
> > * Make the bus-format negotiation logic more generic
> > ---
> > .../display/bridge/lvds-transmitter.txt | 12 ++
> > drivers/gpu/drm/bridge/lvds-encoder.c | 105 ++++++++++++++++++
> > 2 files changed, 117 insertions(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt
> > b/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt
> > index 60091db5dfa5..db51eab216f7 100644
> > --- a/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt
> > +++ b/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt
> > @@ -36,6 +36,18 @@ graph bindings specified in
> > Documentation/devicetree/bindings/graph.txt. - Video port 0 for parallel
> > input
> > - Video port 1 for LVDS output
> >
> > +Optional port 0 node properties:
> > +
> > +- data-mapping: can be one of the following values
> > + "rgb-24"
> > + "rgb-18"
> > +
> > +Optional port 0 node properties:
>
> You probably mean port 1 ^^^ ?
Yes.
>
> Anyway, devicetree doc changes should be separate patch and be send to DT ML
> (I can't see it in CC).
I'll fix that in v3. In the meantime, I'd really like to have feedback
on patches 1 to 16 as this is where core changes are.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-08-26 18:17 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-26 15:26 [PATCH v2 00/21] drm: Add support for bus-format negotiation Boris Brezillon
2019-08-26 15:26 ` [PATCH v2 01/21] drm: Stop including drm_bridge.h from drm_crtc.h Boris Brezillon
2019-08-28 20:27 ` Boris Brezillon
2019-08-26 15:26 ` [PATCH v2 02/21] drm: Add a dummy bridge object to drm_encoder Boris Brezillon
2019-08-26 15:26 ` [PATCH v2 03/21] drm/vc4: Implement bridge_funcs instead of encoder_helper_funcs Boris Brezillon
2019-08-26 15:26 ` [PATCH v2 04/21] drm/exynos: Fix potential unbalanced calls to pm_runtime_put Boris Brezillon
2019-10-11 13:31 ` Boris Brezillon
2019-10-11 13:54 ` Andrzej Hajda
2019-10-11 14:20 ` Boris Brezillon
2019-10-12 7:15 ` Sam Ravnborg
2019-10-22 9:14 ` Boris Brezillon
2019-10-22 17:23 ` Boris Brezillon
2019-08-26 15:26 ` [PATCH v2 05/21] drm/exynos: Don't reset bridge->next Boris Brezillon
2019-08-26 15:26 ` [PATCH v2 06/21] drm/exynos: Implement bridge_funcs instead of encoder_helper_funcs Boris Brezillon
2019-08-26 15:26 ` [PATCH v2 07/21] drm/bridge: Rename bridge helpers targeting a bridge chain Boris Brezillon
2019-08-26 15:26 ` [PATCH v2 08/21] drm/msm: Use drm_attach_bridge() to attach a bridge to an encoder Boris Brezillon
2019-08-28 15:22 ` Sean Paul
2019-08-28 15:25 ` Boris Brezillon
2019-08-28 15:30 ` Sean Paul
2019-08-28 20:27 ` Boris Brezillon
2019-08-26 15:26 ` [PATCH v2 09/21] drm/bridge: Introduce drm_bridge_chain_get_next_bridge() Boris Brezillon
2019-08-27 7:19 ` Neil Armstrong
2019-08-26 15:26 ` [PATCH v2 10/21] drm/bridge: Make the bridge chain a double-linked list Boris Brezillon
2019-08-26 15:26 ` [PATCH v2 11/21] drm/bridge: Add the drm_for_each_bridge_in_chain() helper Boris Brezillon
2019-08-27 7:26 ` Neil Armstrong
2019-08-26 15:26 ` [PATCH v2 12/21] drm/bridge: Add a drm_bridge_state object Boris Brezillon
2019-08-26 15:26 ` [PATCH v2 13/21] drm/bridge: Patch atomic hooks to take a drm_bridge_state Boris Brezillon
2019-08-26 15:26 ` [PATCH v2 14/21] drm/bridge: Add an ->atomic_check() hook Boris Brezillon
2019-08-26 15:26 ` [PATCH v2 15/21] drm/bridge: Add the drm_bridge_chain_get_prev_bridge() helper Boris Brezillon
2019-08-27 7:26 ` Neil Armstrong
2019-08-26 15:26 ` [PATCH v2 16/21] drm/bridge: Add the necessary bits to support bus format negotiation Boris Brezillon
2019-08-27 8:18 ` Neil Armstrong
2019-08-26 15:26 ` [PATCH v2 17/21] drm/imx: pd: Use bus format/flags provided by the bridge when available Boris Brezillon
2019-08-27 8:15 ` Philipp Zabel
2019-08-27 8:43 ` Boris Brezillon
2019-08-27 9:23 ` Philipp Zabel
2019-08-27 9:57 ` Boris Brezillon
2019-08-27 12:51 ` Philipp Zabel
2019-08-27 13:20 ` Boris Brezillon
2019-08-27 13:49 ` Philipp Zabel
2019-08-26 15:26 ` [PATCH v2 18/21] drm/bridge: lvds-encoder: Implement basic bus format negotiation Boris Brezillon
2019-08-26 16:15 ` Jernej Škrabec
2019-08-26 18:17 ` Boris Brezillon [this message]
2019-08-26 15:26 ` [PATCH v2 19/21] drm/bridge: panel: Propage bus format/flags Boris Brezillon
2019-08-26 15:26 ` [PATCH v2 20/21] drm/panel: simple: Add support for Toshiba LTA089AC29000 panel Boris Brezillon
2019-08-26 15:26 ` [PATCH v2 21/21] ARM: dts: imx: imx51-zii-rdu1: Fix the display pipeline definition Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190826201740.28d93350@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=Chris.Healy@zii.aero \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=andrew.smirnov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=kernel@collabora.com \
--cc=kyungmin.park@samsung.com \
--cc=narmstrong@baylibre.com \
--cc=nikita.yoush@cogentembedded.com \
--cc=sam@ravnborg.org \
--cc=sw0312.kim@samsung.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox