[PATCH] drm/msm/adreno: Do not print error on "qcom, gpu-pwrlevels" absence

[PATCH] drm/msm/adreno: Do not print error on "qcom, gpu-pwrlevels" absence

[Fabio Estevam]

Booting the adreno driver on a imx53 board leads to the following
error message:

adreno 30000000.gpu: [drm:adreno_gpu_init] *ERROR* Could not find the GPU powerlevels

As the "qcom,gpu-pwrlevels" property is optional and never present on
i.MX5, turn the message into debug level instead.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
 drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
index 048c8be426f3..73c79f1614c1 100644
--- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c
+++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
@@ -825,7 +825,7 @@ static int adreno_get_legacy_pwrlevels(struct device *dev)
 
 	node = of_get_compatible_child(dev->of_node, "qcom,gpu-pwrlevels");
 	if (!node) {
-		DRM_DEV_ERROR(dev, "Could not find the GPU powerlevels\n");
+		DRM_DEV_DEBUG(dev, "Could not find the GPU powerlevels\n");
 		return -ENXIO;
 	}
 
-- 
2.17.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/msm/adreno: Do not print error on "qcom,gpu-pwrlevels" absence

[Jordan Crouse]

On Thu, Sep 05, 2019 at 08:16:48AM -0300, Fabio Estevam wrote:
> Booting the adreno driver on a imx53 board leads to the following
> error message:
> 
> adreno 30000000.gpu: [drm:adreno_gpu_init] *ERROR* Could not find the GPU powerlevels
> 
> As the "qcom,gpu-pwrlevels" property is optional and never present on
> i.MX5, turn the message into debug level instead.

Sounds legit to me. This is mainly for compatibility with downstream device tree
files and the folks doing DRM on Android should know what they are doing.

Reviewed-by: Jordan Crouse <jcrouse@codeaurora.org>

> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
>  drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> index 048c8be426f3..73c79f1614c1 100644
> --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> @@ -825,7 +825,7 @@ static int adreno_get_legacy_pwrlevels(struct device *dev)
>  
>  	node = of_get_compatible_child(dev->of_node, "qcom,gpu-pwrlevels");
>  	if (!node) {
> -		DRM_DEV_ERROR(dev, "Could not find the GPU powerlevels\n");
> +		DRM_DEV_DEBUG(dev, "Could not find the GPU powerlevels\n");
>  		return -ENXIO;
>  	}
>  
> -- 
> 2.17.1
> 

-- 
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel