* [PATCH] drm/dp-mst: Drop connection_mutex check
@ 2019-10-09 22:41 Daniel Vetter
2019-10-09 22:46 ` Lyude Paul
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Vetter @ 2019-10-09 22:41 UTC (permalink / raw)
To: DRI Development
Cc: Sean Paul, Daniel Vetter, Intel Graphics Development,
Daniel Vetter
Private atomic objects have grown their own locking with
commit b962a12050a387e4bbf3a48745afe1d29d396b0d
Author: Rob Clark <robdclark@gmail.com>
Date: Mon Oct 22 14:31:22 2018 +0200
drm/atomic: integrate modeset lock with private objects
which means we're no longer relying on connection_mutex for mst state
locking needs.
Cc: Lyude Paul <lyude@redhat.com>
Cc: Sean Paul <sean@poorly.run>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
drivers/gpu/drm/drm_dp_mst_topology.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c
index 6b14b63b8d62..9364e4f42975 100644
--- a/drivers/gpu/drm/drm_dp_mst_topology.c
+++ b/drivers/gpu/drm/drm_dp_mst_topology.c
@@ -4186,7 +4186,6 @@ struct drm_dp_mst_topology_state *drm_atomic_get_mst_topology_state(struct drm_a
{
struct drm_device *dev = mgr->dev;
- WARN_ON(!drm_modeset_is_locked(&dev->mode_config.connection_mutex));
return to_dp_mst_topology_state(drm_atomic_get_private_obj_state(state, &mgr->base));
}
EXPORT_SYMBOL(drm_atomic_get_mst_topology_state);
--
2.23.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drm/dp-mst: Drop connection_mutex check
2019-10-09 22:41 [PATCH] drm/dp-mst: Drop connection_mutex check Daniel Vetter
@ 2019-10-09 22:46 ` Lyude Paul
2019-10-10 13:40 ` Daniel Vetter
0 siblings, 1 reply; 3+ messages in thread
From: Lyude Paul @ 2019-10-09 22:46 UTC (permalink / raw)
To: Daniel Vetter, DRI Development
Cc: Daniel Vetter, Intel Graphics Development, Sean Paul
oh, completely forgot about this one
Reviewed-by: Lyude Paul <lyude@redhat.com>
On Thu, 2019-10-10 at 00:41 +0200, Daniel Vetter wrote:
> Private atomic objects have grown their own locking with
>
> commit b962a12050a387e4bbf3a48745afe1d29d396b0d
> Author: Rob Clark <robdclark@gmail.com>
> Date: Mon Oct 22 14:31:22 2018 +0200
>
> drm/atomic: integrate modeset lock with private objects
>
> which means we're no longer relying on connection_mutex for mst state
> locking needs.
>
> Cc: Lyude Paul <lyude@redhat.com>
> Cc: Sean Paul <sean@poorly.run>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
> drivers/gpu/drm/drm_dp_mst_topology.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c
> b/drivers/gpu/drm/drm_dp_mst_topology.c
> index 6b14b63b8d62..9364e4f42975 100644
> --- a/drivers/gpu/drm/drm_dp_mst_topology.c
> +++ b/drivers/gpu/drm/drm_dp_mst_topology.c
> @@ -4186,7 +4186,6 @@ struct drm_dp_mst_topology_state
> *drm_atomic_get_mst_topology_state(struct drm_a
> {
> struct drm_device *dev = mgr->dev;
>
> - WARN_ON(!drm_modeset_is_locked(&dev->mode_config.connection_mutex));
> return
> to_dp_mst_topology_state(drm_atomic_get_private_obj_state(state, &mgr-
> >base));
> }
> EXPORT_SYMBOL(drm_atomic_get_mst_topology_state);
--
Cheers,
Lyude Paul
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/dp-mst: Drop connection_mutex check
2019-10-09 22:46 ` Lyude Paul
@ 2019-10-10 13:40 ` Daniel Vetter
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2019-10-10 13:40 UTC (permalink / raw)
To: Lyude Paul
Cc: Daniel Vetter, Intel Graphics Development, Sean Paul,
DRI Development, Daniel Vetter
On Wed, Oct 09, 2019 at 06:46:38PM -0400, Lyude Paul wrote:
> oh, completely forgot about this one
>
> Reviewed-by: Lyude Paul <lyude@redhat.com>
Thanks for your review, applied to drm-misc-next.
-Daniel
>
> On Thu, 2019-10-10 at 00:41 +0200, Daniel Vetter wrote:
> > Private atomic objects have grown their own locking with
> >
> > commit b962a12050a387e4bbf3a48745afe1d29d396b0d
> > Author: Rob Clark <robdclark@gmail.com>
> > Date: Mon Oct 22 14:31:22 2018 +0200
> >
> > drm/atomic: integrate modeset lock with private objects
> >
> > which means we're no longer relying on connection_mutex for mst state
> > locking needs.
> >
> > Cc: Lyude Paul <lyude@redhat.com>
> > Cc: Sean Paul <sean@poorly.run>
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > ---
> > drivers/gpu/drm/drm_dp_mst_topology.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c
> > b/drivers/gpu/drm/drm_dp_mst_topology.c
> > index 6b14b63b8d62..9364e4f42975 100644
> > --- a/drivers/gpu/drm/drm_dp_mst_topology.c
> > +++ b/drivers/gpu/drm/drm_dp_mst_topology.c
> > @@ -4186,7 +4186,6 @@ struct drm_dp_mst_topology_state
> > *drm_atomic_get_mst_topology_state(struct drm_a
> > {
> > struct drm_device *dev = mgr->dev;
> >
> > - WARN_ON(!drm_modeset_is_locked(&dev->mode_config.connection_mutex));
> > return
> > to_dp_mst_topology_state(drm_atomic_get_private_obj_state(state, &mgr-
> > >base));
> > }
> > EXPORT_SYMBOL(drm_atomic_get_mst_topology_state);
> --
> Cheers,
> Lyude Paul
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-10 13:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-09 22:41 [PATCH] drm/dp-mst: Drop connection_mutex check Daniel Vetter
2019-10-09 22:46 ` Lyude Paul
2019-10-10 13:40 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox