dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Kalyan Thota <kalyan_t-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	dhar-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	travitej-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	nganji-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
	hoegsberg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
	freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	jsanka-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	chandanu-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org
Subject: Re: [PATCH v3] msm:disp:dpu1: add support for display for SC7180 target
Date: Fri, 22 Nov 2019 18:44:36 -0600	[thread overview]
Message-ID: <20191123004436.GA18110@bogus> (raw)
In-Reply-To: <1574252368-4645-1-git-send-email-kalyan_t-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>

On Wed, Nov 20, 2019 at 05:49:28PM +0530, Kalyan Thota wrote:
> Add display hw catalog changes for SC7180 target.
> 
> Changes in v1:
>  - Configure register offsets and capabilities for the
>    display hw blocks.
> 
> Changes in v2:
>  - mdss_irq data type has changed in the dependent
>    patch, accommodate the necessary changes.
>  - Add co-developed-by tags in the commit msg (Stephen Boyd).
> 
> Changes in v3:
>  - fix kernel checkpatch errors in v2

But not the one telling you to split bindings to separate patch?

> 
> This patch has dependency on the below series
> 
> https://patchwork.kernel.org/patch/11253647/
> 
> Co-developed-by: Shubhashree Dhar <dhar@codeaurora.org>
> Signed-off-by: Shubhashree Dhar <dhar@codeaurora.org>
> Co-developed-by: Raviteja Tamatam <travitej@codeaurora.org>
> Signed-off-by: Raviteja Tamatam <travitej@codeaurora.org>
> Signed-off-by: Kalyan Thota <kalyan_t@codeaurora.org>
> ---
>  .../devicetree/bindings/display/msm/dpu.txt        |   4 +-

Acked-by: Rob Herring <robh@kernel.org>

>  drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c     | 189 +++++++++++++++++++--
>  drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h     |   4 +
>  drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c          |   3 +-
>  drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c            |   1 +
>  drivers/gpu/drm/msm/msm_drv.c                      |   4 +-
>  6 files changed, 190 insertions(+), 15 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/msm/dpu.txt b/Documentation/devicetree/bindings/display/msm/dpu.txt
> index a61dd40..512f022 100644
> --- a/Documentation/devicetree/bindings/display/msm/dpu.txt
> +++ b/Documentation/devicetree/bindings/display/msm/dpu.txt
> @@ -8,7 +8,7 @@ The DPU display controller is found in SDM845 SoC.
>  
>  MDSS:
>  Required properties:
> -- compatible: "qcom,sdm845-mdss"
> +- compatible: "qcom,sdm845-mdss", "qcom,sc7180-mdss"
>  - reg: physical base address and length of contoller's registers.
>  - reg-names: register region names. The following region is required:
>    * "mdss"
> @@ -41,7 +41,7 @@ Optional properties:
>  
>  MDP:
>  Required properties:
> -- compatible: "qcom,sdm845-dpu"
> +- compatible: "qcom,sdm845-dpu", "qcom,sc7180-dpu"
>  - reg: physical base address and length of controller's registers.
>  - reg-names : register region names. The following region is required:
>    * "mdp"
_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Kalyan Thota <kalyan_t@codeaurora.org>
Cc: devicetree@vger.kernel.org, dhar@codeaurora.org,
	travitej@codeaurora.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	seanpaul@chromium.org, hoegsberg@chromium.org,
	freedreno@lists.freedesktop.org, chandanu@codeaurora.org
Subject: Re: [PATCH v3] msm:disp:dpu1: add support for display for SC7180 target
Date: Fri, 22 Nov 2019 18:44:36 -0600	[thread overview]
Message-ID: <20191123004436.GA18110@bogus> (raw)
Message-ID: <20191123004436.vHLTZrzf4QFmjIO2B-Ww9YxgcPCaFBatm22ijYIhuoM@z> (raw)
In-Reply-To: <1574252368-4645-1-git-send-email-kalyan_t@codeaurora.org>

On Wed, Nov 20, 2019 at 05:49:28PM +0530, Kalyan Thota wrote:
> Add display hw catalog changes for SC7180 target.
> 
> Changes in v1:
>  - Configure register offsets and capabilities for the
>    display hw blocks.
> 
> Changes in v2:
>  - mdss_irq data type has changed in the dependent
>    patch, accommodate the necessary changes.
>  - Add co-developed-by tags in the commit msg (Stephen Boyd).
> 
> Changes in v3:
>  - fix kernel checkpatch errors in v2

But not the one telling you to split bindings to separate patch?

> 
> This patch has dependency on the below series
> 
> https://patchwork.kernel.org/patch/11253647/
> 
> Co-developed-by: Shubhashree Dhar <dhar@codeaurora.org>
> Signed-off-by: Shubhashree Dhar <dhar@codeaurora.org>
> Co-developed-by: Raviteja Tamatam <travitej@codeaurora.org>
> Signed-off-by: Raviteja Tamatam <travitej@codeaurora.org>
> Signed-off-by: Kalyan Thota <kalyan_t@codeaurora.org>
> ---
>  .../devicetree/bindings/display/msm/dpu.txt        |   4 +-

Acked-by: Rob Herring <robh@kernel.org>

>  drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c     | 189 +++++++++++++++++++--
>  drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h     |   4 +
>  drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c          |   3 +-
>  drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c            |   1 +
>  drivers/gpu/drm/msm/msm_drv.c                      |   4 +-
>  6 files changed, 190 insertions(+), 15 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/msm/dpu.txt b/Documentation/devicetree/bindings/display/msm/dpu.txt
> index a61dd40..512f022 100644
> --- a/Documentation/devicetree/bindings/display/msm/dpu.txt
> +++ b/Documentation/devicetree/bindings/display/msm/dpu.txt
> @@ -8,7 +8,7 @@ The DPU display controller is found in SDM845 SoC.
>  
>  MDSS:
>  Required properties:
> -- compatible: "qcom,sdm845-mdss"
> +- compatible: "qcom,sdm845-mdss", "qcom,sc7180-mdss"
>  - reg: physical base address and length of contoller's registers.
>  - reg-names: register region names. The following region is required:
>    * "mdss"
> @@ -41,7 +41,7 @@ Optional properties:
>  
>  MDP:
>  Required properties:
> -- compatible: "qcom,sdm845-dpu"
> +- compatible: "qcom,sdm845-dpu", "qcom,sc7180-dpu"
>  - reg: physical base address and length of controller's registers.
>  - reg-names : register region names. The following region is required:
>    * "mdp"
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2019-11-23  0:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-20 12:19 [PATCH v3] msm:disp:dpu1: add support for display for SC7180 target Kalyan Thota
2019-11-20 12:19 ` Kalyan Thota
     [not found] ` <1574252368-4645-1-git-send-email-kalyan_t-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2019-11-23  0:44   ` Rob Herring [this message]
2019-11-23  0:44     ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191123004436.GA18110@bogus \
    --to=robh-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=chandanu-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=dhar-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=hoegsberg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=jsanka-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=kalyan_t-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=nganji-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=travitej-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox