From: Daniel Vetter <daniel-/w4YWyX8dFk@public.gmane.org>
To: Emil Velikov <emil.l.velikov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Alex Deucher <alexander.deucher-5C7GfCeVMHo@public.gmane.org>,
Boris Brezillon
<boris.brezillon-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>,
Sean Paul <sean-p7yTbzM4H96eqtR555YLDQ@public.gmane.org>,
ML dri-devel
<dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
amd-gfx mailing list
<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Subject: Re: [PATCH 5/5] drm: drop DRM_AUTH from PRIME_TO/FROM_HANDLE ioctls
Date: Wed, 27 Nov 2019 19:04:56 +0100 [thread overview]
Message-ID: <20191127180456.GD406127@phenom.ffwll.local> (raw)
In-Reply-To: <CACvgo52UB-sAv55_kREgHbRsg6b5KXv7At0TbgUPdc0e1E+QaA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Wed, Nov 27, 2019 at 04:27:29PM +0000, Emil Velikov wrote:
> On Wed, 27 Nov 2019 at 07:41, Boris Brezillon
> <boris.brezillon@collabora.com> wrote:
> >
> > Hi Emil,
> >
> > On Fri, 1 Nov 2019 13:03:13 +0000
> > Emil Velikov <emil.l.velikov@gmail.com> wrote:
> >
> > > From: Emil Velikov <emil.velikov@collabora.com>
> > >
> > > As mentioned by Christian, for drivers which support only primary nodes
> > > this changes the returned error from -EACCES into -EOPNOTSUPP/-ENOSYS.
> >
> > Are you sure this is true for MODESET-only nodes (those that do not
> > have the RENDER cap set) implementing ->{fd_to_handle,handle_to_fd}()?
> > Shouldn't the is_authenticated() check still be done in that case?
> >
> Thanks for catching this. Just sent out v2, which I should address the concern.
Why do we need this additional check in v2? What can go wrong on modeset
drivers if non-authenticated legacy things can use this? modeset-only
drivers have all their resources segregated by the drm core (drm_fb,
mmaps, buffer lists), so there's really no access limitations that can go
wrong here.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: Alex Deucher <alexander.deucher@amd.com>,
Boris Brezillon <boris.brezillon@collabora.com>,
Sean Paul <sean@poorly.run>,
ML dri-devel <dri-devel@lists.freedesktop.org>,
amd-gfx mailing list <amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 5/5] drm: drop DRM_AUTH from PRIME_TO/FROM_HANDLE ioctls
Date: Wed, 27 Nov 2019 19:04:56 +0100 [thread overview]
Message-ID: <20191127180456.GD406127@phenom.ffwll.local> (raw)
Message-ID: <20191127180456.aA0zthaSUoGslSRzMLPq5wpmH11QeRdXYpZoaX76muY@z> (raw)
In-Reply-To: <CACvgo52UB-sAv55_kREgHbRsg6b5KXv7At0TbgUPdc0e1E+QaA@mail.gmail.com>
On Wed, Nov 27, 2019 at 04:27:29PM +0000, Emil Velikov wrote:
> On Wed, 27 Nov 2019 at 07:41, Boris Brezillon
> <boris.brezillon@collabora.com> wrote:
> >
> > Hi Emil,
> >
> > On Fri, 1 Nov 2019 13:03:13 +0000
> > Emil Velikov <emil.l.velikov@gmail.com> wrote:
> >
> > > From: Emil Velikov <emil.velikov@collabora.com>
> > >
> > > As mentioned by Christian, for drivers which support only primary nodes
> > > this changes the returned error from -EACCES into -EOPNOTSUPP/-ENOSYS.
> >
> > Are you sure this is true for MODESET-only nodes (those that do not
> > have the RENDER cap set) implementing ->{fd_to_handle,handle_to_fd}()?
> > Shouldn't the is_authenticated() check still be done in that case?
> >
> Thanks for catching this. Just sent out v2, which I should address the concern.
Why do we need this additional check in v2? What can go wrong on modeset
drivers if non-authenticated legacy things can use this? modeset-only
drivers have all their resources segregated by the drm core (drm_fb,
mmaps, buffer lists), so there's really no access limitations that can go
wrong here.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-11-27 18:04 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 13:03 [PATCH 1/5] drm/vmwgfx: move the require_exist handling together Emil Velikov
2019-11-01 13:03 ` [PATCH 2/5] drm/vmwgfx: check master authentication in surface_ref ioctls Emil Velikov
2019-11-12 12:53 ` Thomas Hellstrom
2019-11-01 13:03 ` [PATCH 3/5] drm/vmwgfx: drop DRM_AUTH for render ioctls Emil Velikov
2019-11-12 12:54 ` Thomas Hellstrom
2019-11-13 14:48 ` Emil Velikov
2019-11-01 13:03 ` [PATCH 4/5] drm/panfrost: remove DRM_AUTH and respective comment Emil Velikov
2019-11-01 13:34 ` Steven Price
2019-11-08 13:10 ` Emil Velikov
2019-11-08 15:55 ` Steven Price
2019-11-08 16:42 ` Emil Velikov
2019-11-01 13:03 ` [PATCH 5/5] drm: drop DRM_AUTH from PRIME_TO/FROM_HANDLE ioctls Emil Velikov
[not found] ` <20191101130313.8862-5-emil.l.velikov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-11-08 13:11 ` Emil Velikov
2019-11-08 13:11 ` Emil Velikov
2019-11-27 7:41 ` Boris Brezillon
2019-11-27 16:27 ` Emil Velikov
[not found] ` <CACvgo52UB-sAv55_kREgHbRsg6b5KXv7At0TbgUPdc0e1E+QaA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-11-27 18:04 ` Daniel Vetter [this message]
2019-11-27 18:04 ` Daniel Vetter
[not found] ` <20191127180456.GD406127-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2019-11-27 18:32 ` Emil Velikov
2019-11-27 18:32 ` Emil Velikov
[not found] ` <CACvgo50j0sU18-AqeerkgDq9joJysT_0PuQrgVS1tVhUqV9rcg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-11-27 18:37 ` Daniel Vetter
2019-11-27 18:37 ` Daniel Vetter
[not found] ` <20191127183700.GN406127-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2019-12-02 17:20 ` Emil Velikov
2019-12-02 17:20 ` Emil Velikov
2019-11-27 16:25 ` [PATCH v2] " Emil Velikov
2019-11-08 13:13 ` [PATCH 1/5] drm/vmwgfx: move the require_exist handling together Emil Velikov
2019-11-08 15:22 ` Thomas Hellstrom
2019-11-12 12:50 ` Thomas Hellstrom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191127180456.GD406127@phenom.ffwll.local \
--to=daniel-/w4ywyx8dfk@public.gmane.org \
--cc=alexander.deucher-5C7GfCeVMHo@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=boris.brezillon-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=emil.l.velikov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=sean-p7yTbzM4H96eqtR555YLDQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox