From: Sam Ravnborg <sam@ravnborg.org>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: puck.chen@hisilicon.com, dri-devel@lists.freedesktop.org,
kong.kongxinwei@hisilicon.com, kraxel@redhat.com,
zourongrong@gmail.com, airlied@redhat.com
Subject: Re: [PATCH v2 0/3] drm/vram-helper: Various cleanups
Date: Thu, 12 Dec 2019 10:49:30 +0100 [thread overview]
Message-ID: <20191212094930.GA32429@ravnborg.org> (raw)
In-Reply-To: <20191212074117.29283-1-tzimmermann@suse.de>
Hi Thomas.
On Thu, Dec 12, 2019 at 08:41:14AM +0100, Thomas Zimmermann wrote:
> A number of cleanups that I wanted to apply for some time. The first
> two patches simplify the public interface. The third patch adds support
> for struct drm_driver.gem_create_object. All tested by running fbdev,
> X11 and Weston on ast HW.
>
> v2:
> * make drm_gem_vram_create() still work if GEM object is not
> first in struct
>
> Thomas Zimmermann (3):
> drm/vram-helper: Remove interruptible flag from public interface
> drm/vram-helper: Remove BO device from public interface
> drm/vram-helper: Support struct drm_driver.gem_create_object
I have browsed the code changes - everything now looks fine.
As I miss the high-level picture (which is just my lack of DRM
knowledge) this is not a review. But you can add my:
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-12-12 9:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 7:41 [PATCH v2 0/3] drm/vram-helper: Various cleanups Thomas Zimmermann
2019-12-12 7:41 ` [PATCH v2 1/3] drm/vram-helper: Remove interruptible flag from public interface Thomas Zimmermann
2019-12-12 7:41 ` [PATCH v2 2/3] drm/vram-helper: Remove BO device " Thomas Zimmermann
2019-12-12 7:41 ` [PATCH v2 3/3] drm/vram-helper: Support struct drm_driver.gem_create_object Thomas Zimmermann
2019-12-13 10:27 ` Daniel Vetter
2020-01-06 10:20 ` Thomas Zimmermann
2019-12-12 9:49 ` Sam Ravnborg [this message]
2019-12-12 10:26 ` [PATCH v2 0/3] drm/vram-helper: Various cleanups Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191212094930.GA32429@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kong.kongxinwei@hisilicon.com \
--cc=kraxel@redhat.com \
--cc=puck.chen@hisilicon.com \
--cc=tzimmermann@suse.de \
--cc=zourongrong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox